From patchwork Thu Sep 3 23:18:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 7119531 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9D7869F380 for ; Thu, 3 Sep 2015 23:18:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D0E8B20801 for ; Thu, 3 Sep 2015 23:18:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E11D02080B for ; Thu, 3 Sep 2015 23:18:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758067AbbICXSJ (ORCPT ); Thu, 3 Sep 2015 19:18:09 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:36297 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757981AbbICXSI (ORCPT ); Thu, 3 Sep 2015 19:18:08 -0400 Received: by lbcao8 with SMTP id ao8so2365655lbc.3 for ; Thu, 03 Sep 2015 16:18:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Im0LuZyCqUWW6AtGO5P8GOb8a4HRZPvltE6xUmbluVc=; b=kCFAQZtP0O+umhqfFbCPYxKSufaRoVUdIgyx6vK+paruPWCIslqOszx08ywlZs8hjd UxvOFVv1tsSU7yLmx49wDBrtzY2UeUGeHJGkZiti7lKRVexsQkC3e7UTsJZhF7dLFG6I KrK/1UJ/0OoLEcimEyrsWCpiiC+U4c8vww1qSifgSPmhTRQY1YEbYwvwhp6Vu9LwHHWk gSOJS1/FUi3hTlfu0Bm49YdaQY7UazHI2slVOxZBgm3naPq0uDARPHrqyI8MwRKjPEuj RlVR6XBattnzrRt1vy96nO1NPk2J35OXzkqVCSeXXS8GgMAeOzPQjPgZa1RZ/jzVEvRo wH8g== X-Gm-Message-State: ALoCoQl6EacNkvX7goyALeZ9y85pO7LAqr9vwtjDAQD2uzXn+jzXahua6Npdpx7/Zco6xua1fC/C X-Received: by 10.152.244.170 with SMTP id xh10mr482230lac.7.1441322287069; Thu, 03 Sep 2015 16:18:07 -0700 (PDT) Received: from wasted.cogentembedded.com (ppp17-93.pppoe.mtu-net.ru. [81.195.17.93]) by smtp.gmail.com with ESMTPSA id lb9sm98098lab.7.2015.09.03.16.18.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Sep 2015 16:18:06 -0700 (PDT) From: Sergei Shtylyov To: g.liakhovetski@gmx.de, mchehab@osg.samsung.com, linux-media@vger.kernel.org Cc: linux-sh@vger.kernel.org Subject: [PATCH 3/3] rcar_vin: call g_std() instead of querystd() Date: Fri, 04 Sep 2015 02:18:05 +0300 Message-ID: <2719391.j5OZOaG8ai@wasted.cogentembedded.com> Organization: Cogent Embedded Inc. User-Agent: KMail/4.14.9 (Linux/4.1.5-100.fc21.x86_64; KDE/4.14.9; x86_64; ; ) In-Reply-To: <6015647.cjLjRfTWc7@wasted.cogentembedded.com> References: <6015647.cjLjRfTWc7@wasted.cogentembedded.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hans Verkuil says: "The only place querystd can be called is in the QUERYSTD ioctl, all other ioctls should use the last set standard." So call the g_std() subdevice method instead of querystd() in the driver's set_fmt() method. Reported-by: Hans Verkuil Signed-off-by: Sergei Shtylyov Acked-by: Hans Verkuil --- drivers/media/platform/soc_camera/rcar_vin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: media_tree/drivers/media/platform/soc_camera/rcar_vin.c =================================================================== --- media_tree.orig/drivers/media/platform/soc_camera/rcar_vin.c +++ media_tree/drivers/media/platform/soc_camera/rcar_vin.c @@ -1589,8 +1589,8 @@ static int rcar_vin_set_fmt(struct soc_c field = pix->field; break; case V4L2_FIELD_INTERLACED: - /* Query for standard if not explicitly mentioned _TB/_BT */ - ret = v4l2_subdev_call(sd, video, querystd, &std); + /* Get the last standard if not explicitly mentioned _TB/_BT */ + ret = v4l2_subdev_call(sd, video, g_std, &std); if (ret == -ENOIOCTLCMD) { field = V4L2_FIELD_NONE; } else if (ret < 0) {