diff mbox

[-next] media/platform/cadence: add <linux/slab.h> to fix build error

Message ID 2feda2a7-8008-f36d-67fa-a4aa38ea75ae@infradead.org (mailing list archive)
State New, archived
Headers show

Commit Message

Randy Dunlap June 8, 2018, 9:19 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Add #include <linux/slab.h> to fix build errors.
This driver uses kzalloc() and kfree() so it needs to #include
the appropriate header file for those interfaces.

Fixes these build errors:

../drivers/media/platform/cadence/cdns-csi2rx.c: In function 'csi2rx_probe':
../drivers/media/platform/cadence/cdns-csi2rx.c:421:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
  csi2rx = kzalloc(sizeof(*csi2rx), GFP_KERNEL);
../drivers/media/platform/cadence/cdns-csi2rx.c:421:9: warning: assignment makes pointer from integer without a cast [enabled by default]
  csi2rx = kzalloc(sizeof(*csi2rx), GFP_KERNEL);
../drivers/media/platform/cadence/cdns-csi2rx.c:466:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
  kfree(csi2rx);

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
---
 drivers/media/platform/cadence/cdns-csi2rx.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Maxime Ripard June 11, 2018, 7:36 a.m. UTC | #1 
On Fri, Jun 08, 2018 at 02:19:06PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Add #include <linux/slab.h> to fix build errors.
> This driver uses kzalloc() and kfree() so it needs to #include
> the appropriate header file for those interfaces.
> 
> Fixes these build errors:
> 
> ../drivers/media/platform/cadence/cdns-csi2rx.c: In function 'csi2rx_probe':
> ../drivers/media/platform/cadence/cdns-csi2rx.c:421:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration]
>   csi2rx = kzalloc(sizeof(*csi2rx), GFP_KERNEL);
> ../drivers/media/platform/cadence/cdns-csi2rx.c:421:9: warning: assignment makes pointer from integer without a cast [enabled by default]
>   csi2rx = kzalloc(sizeof(*csi2rx), GFP_KERNEL);
> ../drivers/media/platform/cadence/cdns-csi2rx.c:466:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration]
>   kfree(csi2rx);
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>

Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Thanks!
Maxime
diff mbox

Patch

--- linux-next-20180608.orig/drivers/media/platform/cadence/cdns-csi2rx.c
+++ linux-next-20180608/drivers/media/platform/cadence/cdns-csi2rx.c
@@ -13,6 +13,7 @@ 
 #include <linux/of_graph.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-device.h>