| Message ID | 386df6b4-f213-4b7f-b9e7-94672c5287d4@xs4all.nl (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [GIT,PULL,FOR,v6.13] media: various wait_prepare/finish fixes | expand |
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/386df6b4-f213-4b7f-b9e7-94672c5287d4@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/389543/
Build time: 00:13:03
Link: https://lore.kernel.org/linux-media/386df6b4-f213-4b7f-b9e7-94672c5287d4@xs4all.nl
gpg: Signature made Tue 08 Oct 2024 08:58:36 AM UTC
gpg: using EDDSA key 52ADCAAE8A4F70B99ACD8D726B425DF79B1C1E76
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [expired]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [expired]
gpg: hverkuil@xs4all.nl: Verified 5 signatures in the past 2 months. Encrypted
0 messages.
gpg: hverkuil-cisco@xs4all.nl: Verified 5 signatures in the past 2 months.
Encrypted 0 messages.
gpg: Warning: you have yet to encrypt a message to this key!
gpg: Warning: if you think you've seen more signatures by this key and these
user ids, then this key might be a forgery! Carefully examine the email
addresses for small variations. If the key is suspect, then use
gpg --tofu-policy bad 052CDE7BC215053B689F1BCABD2D614866143B4C
to mark it as being bad.
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F 1BCA BD2D 6148 6614 3B4C
Subkey fingerprint: 52AD CAAE 8A4F 70B9 9ACD 8D72 6B42 5DF7 9B1C 1E76
Summary: no issues. All 11 looked fine.
This series fixes a few wait_prepare/finish issues (either missing altogether, or the lock field was set after the call to vb2_queue_init instead of before), and in the last two patches it adds a sanity check for the lock and implements a default version for wait_prepare/finish() if the driver does not supply those functions. With this in place most (all?) drivers that use vb2_ops_wait_prepare/finish can drop those functions and the end goal is to drop those ops altogether. Regards, Hans The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc: Linux 6.12-rc1 (2024-09-29 15:06:19 -0700) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v6.13b for you to fetch changes up to 3d882f3a391dbc10d53cfb647d469d68a62a1c5b: media: vb2: use lock if wait_prepare/finish are NULL (2024-10-02 11:53:42 +0200) ---------------------------------------------------------------- Tag branch ---------------------------------------------------------------- Hans Verkuil (11): media: omap3isp: add missing wait_prepare/finish ops media: pisp_be: add missing wait_prepare/finish ops media: venus: add missing wait_prepare/finish ops media: pwc: set lock before calling vb2_queue_init() media: msi2500: set lock before calling vb2_queue_init() media: hackrf: set lock before calling vb2_queue_init() media: airspy: set lock before calling vb2_queue_init() media: rcar_drif.c: set lock before calling vb2_queue_init() media: video-i2c: set lock before calling vb2_queue_init() media: vb2: vb2_core_queue_init(): sanity check lock and wait_prepare/finish media: vb2: use lock if wait_prepare/finish are NULL drivers/media/common/videobuf2/videobuf2-core.c | 21 ++++++++++++++++++--- drivers/media/i2c/video-i2c.c | 2 +- drivers/media/platform/qcom/venus/vdec.c | 2 ++ drivers/media/platform/qcom/venus/venc.c | 2 ++ drivers/media/platform/raspberrypi/pisp_be/pisp_be.c | 2 ++ drivers/media/platform/renesas/rcar_drif.c | 2 +- drivers/media/platform/ti/omap3isp/ispvideo.c | 18 ++++++++++++++++++ drivers/media/usb/airspy/airspy.c | 2 +- drivers/media/usb/hackrf/hackrf.c | 4 ++-- drivers/media/usb/msi2500/msi2500.c | 2 +- drivers/media/usb/pwc/pwc-if.c | 2 +- 11 files changed, 49 insertions(+), 10 deletions(-)