| Message ID | 3d9230b2ced520c413291a5f69ed7ef672920194.1441540862.git.mchehab@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mauro, Thank you for the patch. In the subject line, s/interate between all/iterate over all/ On Sunday 06 September 2015 09:03:05 Mauro Carvalho Chehab wrote: > Just like we do with entities, use a similar macro for the > interfaces loop. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > diff --git a/drivers/media/dvb-core/dvbdev.c > b/drivers/media/dvb-core/dvbdev.c index 6babc688801b..f00f1a5f279c 100644 > --- a/drivers/media/dvb-core/dvbdev.c > +++ b/drivers/media/dvb-core/dvbdev.c > @@ -578,9 +578,10 @@ void dvb_create_media_graph(struct dvb_adapter *adap) > } > > /* Create indirect interface links for FE->tuner, DVR->demux and CA->ca */ > - list_for_each_entry(intf, &mdev->interfaces, list) { > + media_device_for_each_intf(intf, mdev) { > if (intf->type == MEDIA_INTF_T_DVB_CA && ca) > media_create_intf_link(ca, intf, 0); > + > if (intf->type == MEDIA_INTF_T_DVB_FE && tuner) > media_create_intf_link(tuner, intf, 0); > > diff --git a/include/media/media-device.h b/include/media/media-device.h > index 51807efa505b..f23d686aaac6 100644 > --- a/include/media/media-device.h > +++ b/include/media/media-device.h > @@ -113,6 +113,11 @@ struct media_device *media_device_find_devres(struct > device *dev); #define media_device_for_each_entity(entity, mdev) \ > list_for_each_entry(entity, &(mdev)->entities, list) > > +/* Iterate over all interfaces. */ > +#define media_device_for_each_intf(intf, mdev) \ > + list_for_each_entry(intf, &(mdev)->interfaces, list) > + > + One blank line should be enough. > #else > static inline int media_device_register(struct media_device *mdev) > {
diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index 6babc688801b..f00f1a5f279c 100644 --- a/drivers/media/dvb-core/dvbdev.c +++ b/drivers/media/dvb-core/dvbdev.c @@ -578,9 +578,10 @@ void dvb_create_media_graph(struct dvb_adapter *adap) } /* Create indirect interface links for FE->tuner, DVR->demux and CA->ca */ - list_for_each_entry(intf, &mdev->interfaces, list) { + media_device_for_each_intf(intf, mdev) { if (intf->type == MEDIA_INTF_T_DVB_CA && ca) media_create_intf_link(ca, intf, 0); + if (intf->type == MEDIA_INTF_T_DVB_FE && tuner) media_create_intf_link(tuner, intf, 0); diff --git a/include/media/media-device.h b/include/media/media-device.h index 51807efa505b..f23d686aaac6 100644 --- a/include/media/media-device.h +++ b/include/media/media-device.h @@ -113,6 +113,11 @@ struct media_device *media_device_find_devres(struct device *dev); #define media_device_for_each_entity(entity, mdev) \ list_for_each_entry(entity, &(mdev)->entities, list) +/* Iterate over all interfaces. */ +#define media_device_for_each_intf(intf, mdev) \ + list_for_each_entry(intf, &(mdev)->interfaces, list) + + #else static inline int media_device_register(struct media_device *mdev) {