| Message ID | 49874612.1000109@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Mon, 02 Feb 2009 20:14:26 +0100 Erik Andrén <erik.andren@gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > The m5602 gspca driver has two sensors offering the possiblity to > control the green balance. This patch adds a v4l2 ctrl for this. Your patch looks OK. Could you please add also the changes at V4L2 spec? Cheers, Mauro. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Erik, On Thursday 26 February 2009 13:04:47 Mauro Carvalho Chehab wrote: > On Mon, 02 Feb 2009 20:14:26 +0100 > > Erik Andrén <erik.andren@gmail.com> wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Hi, > > > > The m5602 gspca driver has two sensors offering the possiblity to > > control the green balance. This patch adds a v4l2 ctrl for this. What's a "green balance" exactly ? The "red balance" and "blue balance" controls make up the two components of the white balance control (which can also be expressed in color temperature units). How does the "green balance" relate to those ? Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -r 24361cfb8615 linux/include/linux/videodev2.h --- a/linux/include/linux/videodev2.h Wed Jan 28 16:55:17 2009 +0100 +++ b/linux/include/linux/videodev2.h Wed Jan 28 17:11:39 2009 +0100 @@ -879,8 +879,10 @@ #define V4L2_CID_BACKLIGHT_COMPENSATION (V4L2_CID_BASE+28) #define V4L2_CID_CHROMA_AGC (V4L2_CID_BASE+29) #define V4L2_CID_COLOR_KILLER (V4L2_CID_BASE+30) + +#define V4L2_CID_GREEN_BALANCE (V4L2_CID_BASE+31) /* last CID + 1 */ -#define V4L2_CID_LASTP1 (V4L2_CID_BASE+31) +#define V4L2_CID_LASTP1 (V4L2_CID_BASE+32) /* MPEG-class control IDs defined by V4L2 */ #define V4L2_CID_MPEG_BASE (V4L2_CTRL_CLASS_MPEG | 0x900)
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, The m5602 gspca driver has two sensors offering the possiblity to control the green balance. This patch adds a v4l2 ctrl for this. Regards, Erik Signed-off-by: Erik Andrén <erik.andren@gmail.com> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkmHRhEACgkQN7qBt+4UG0FAKACgsnXERjLdZL/D+2Ze3KkC6GJc PowAnAkr/0+IT2jB00qCUuqS7OhBmhtG =UfNN -----END PGP SIGNATURE-----