diff mbox

decrement address_err as well as retries.

Message ID 49876E08.1050704@gmail.com (mailing list archive)
State Superseded
Headers show

Commit Message

Roel Kluin Feb. 2, 2009, 10:04 p.m. UTC 
Since we want to determine whether every retry we had an address_err,
and we decrement retries, we should decrement address_err as well.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/common/saa7146_i2c.c b/drivers/media/common/saa7146_i2c.c
index c11da4d..2fac001 100644
--- a/drivers/media/common/saa7146_i2c.c
+++ b/drivers/media/common/saa7146_i2c.c
@@ -293,7 +293,7 @@  static int saa7146_i2c_transfer(struct saa7146_dev *dev, const struct i2c_msg *m
 	int i = 0, count = 0;
 	__le32 *buffer = dev->d_i2c.cpu_addr;
 	int err = 0;
-	int address_err = 0;
+	int address_err = retries;
 	int short_delay = 0;
 
 	if (mutex_lock_interruptible(&dev->i2c_lock))
@@ -342,7 +342,7 @@  static int saa7146_i2c_transfer(struct saa7146_dev *dev, const struct i2c_msg *m
 					if( 0 != (SAA7146_USE_I2C_IRQ & dev->ext->flags)) {
 						goto out;
 					}
-					address_err++;
+					address_err--;
 				}
 				DEB_I2C(("error while sending message(s). starting again.\n"));
 				break;