From patchwork Fri Mar 27 09:35:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 14709 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2R9ZFc4018372 for ; Fri, 27 Mar 2009 09:35:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757609AbZC0JeE (ORCPT ); Fri, 27 Mar 2009 05:34:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757303AbZC0JeD (ORCPT ); Fri, 27 Mar 2009 05:34:03 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39242 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757915AbZC0Jd7 (ORCPT ); Fri, 27 Mar 2009 05:33:59 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2R9Xswh023934; Fri, 27 Mar 2009 05:33:54 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2R9XldB031023; Fri, 27 Mar 2009 05:33:47 -0400 Received: from localhost.localdomain (vpn-10-201.str.redhat.com [10.32.10.201]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2R9Xq6G020971; Fri, 27 Mar 2009 05:33:53 -0400 Message-ID: <49CC9DEF.8020009@redhat.com> Date: Fri, 27 Mar 2009 10:35:43 +0100 From: Hans de Goede User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090303 Fedora/3.0-1.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Jean-Francois Moine CC: linux-media@vger.kernel.org, Ricardo Jorge da Fonseca Marques Ferreira Subject: [PATCH]: gspca: use usb interface as parent X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi all, As discussed in the: "v4l parent for usb device interface or device?" thread, here is a patch for gspca to make it use the usb interface as its parent device, instead of the usb device. Regards, Hans p.s. I'll also push a patch to my libv4l repo, with matching libv4l changes so that libv4l's upside down cam detections stays working with this change. Note: this libv4l patch also fixes libv4l upside down detection for the new device numbering style. diff -r c28651a2c2c3 linux/drivers/media/video/gspca/gspca.c --- a/linux/drivers/media/video/gspca/gspca.c Thu Mar 26 09:44:15 2009 +0100 +++ b/linux/drivers/media/video/gspca/gspca.c Fri Mar 27 10:32:24 2009 +0100 @@ -1958,7 +1958,7 @@ /* init video stuff */ memcpy(&gspca_dev->vdev, &gspca_template, sizeof gspca_template); - gspca_dev->vdev.parent = &dev->dev; + gspca_dev->vdev.parent = &intf->dev; gspca_dev->module = module; gspca_dev->present = 1; ret = video_register_device(&gspca_dev->vdev,