diff mbox

zoran: Fix &&/|| typo

Message ID 49FCB2A4.2000609@gmail.com (mailing list archive)
State Accepted
Headers show

Commit Message

Roel Kluin May 2, 2009, 8:52 p.m. UTC 
Fix &&/|| typo

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Alexey Klimov May 2, 2009, 9:18 p.m. UTC | #1 
Hello, Roel

On Sun, May 3, 2009 at 12:52 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
> Fix &&/|| typo
>
> diff --git a/drivers/media/video/zoran/zoran_card.c b/drivers/media/video/zoran/zoran_card.c
> index ea6c577..ea9de8b 100644
> --- a/drivers/media/video/zoran/zoran_card.c
> +++ b/drivers/media/video/zoran/zoran_card.c
> @@ -1022,7 +1022,7 @@ zr36057_init (struct zoran *zr)
>        zr->vbuf_bytesperline = 0;
>
>        /* Avoid nonsense settings from user for default input/norm */
> -       if (default_norm < 0 && default_norm > 2)
> +       if (default_norm < 0 || default_norm > 2)
>                default_norm = 0;
>        if (default_norm == 0) {
>                zr->norm = V4L2_STD_PAL;

Please, remember that all patches that you send need 'Signed-off-by' field.
And i'm out of touch with events, but probably it's better to make
description more dilated/patulous (i'm not sure here).
diff mbox

Patch

diff --git a/drivers/media/video/zoran/zoran_card.c b/drivers/media/video/zoran/zoran_card.c
index ea6c577..ea9de8b 100644
--- a/drivers/media/video/zoran/zoran_card.c
+++ b/drivers/media/video/zoran/zoran_card.c
@@ -1022,7 +1022,7 @@  zr36057_init (struct zoran *zr)
 	zr->vbuf_bytesperline = 0;
 
 	/* Avoid nonsense settings from user for default input/norm */
-	if (default_norm < 0 && default_norm > 2)
+	if (default_norm < 0 || default_norm > 2)
 		default_norm = 0;
 	if (default_norm == 0) {
 		zr->norm = V4L2_STD_PAL;