| Message ID | 4A754393.4090502@magic.ms (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Mauro Carvalho Chehab |
| Headers | show |
Hi Mauro, please pull from http://linuxtv.org/hg/~tmerle/v4l-dvb the following patch from Eberhard Mattes: - dvb-usb: fix tuning with Cinergy T2 http://linuxtv.org/hg/~tmerle/v4l-dvb/rev/75be92928287 Eberhard, thanks for this bugfix, I did not have time nor hardware to work on that and you did a great investigation job. cinergyT2-fe.c | 1 + 1 file changed, 1 insertion(+) Cheers, Thierry -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c 2009-06-10 05:05:27.000000000 +0200 +++ b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c 2009-08-02 09:28:55.000000000 +0200 @@ -275,6 +275,7 @@ static int cinergyt2_fe_set_frontend(str param.tps = cpu_to_le16(compute_tps(fep)); param.freq = cpu_to_le32(fep->frequency / 1000); param.bandwidth = 8 - fep->u.ofdm.bandwidth - BANDWIDTH_8_MHZ; + param.flags = 0; err = dvb_usb_generic_rw(state->d, (char *)¶m, sizeof(param),
Initialize param.flags. Signed-off-by: Eberhard Mattes <eberhard.mattes@web.de> --- Not setting param.flags was the real cause of the inability of the Cinergy T2 driver to tune under certain circumstances. Moving stuff from the stack to the heap did not really solve the problem. As there are several other drivers which pass buffers on the stack to the USB layer, I leave fixing that to others. This patch is against 2.6.30. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html