From patchwork Sat Aug 22 17:43:50 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Castellano X-Patchwork-Id: 43312 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7MHibEg001851 for ; Sat, 22 Aug 2009 17:44:37 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932832AbZHVRob (ORCPT ); Sat, 22 Aug 2009 13:44:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755636AbZHVRob (ORCPT ); Sat, 22 Aug 2009 13:44:31 -0400 Received: from mail-ew0-f207.google.com ([209.85.219.207]:42383 "EHLO mail-ew0-f207.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690AbZHVRoa (ORCPT ); Sat, 22 Aug 2009 13:44:30 -0400 Received: by ewy3 with SMTP id 3so1389848ewy.18 for ; Sat, 22 Aug 2009 10:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:x-enigmail-version :content-type; bh=YOC6bEsnbYbzsrLyzNCfSUmMpnYunuGpjE4cDqHlJ4I=; b=kxVKpIDAZ9lezdcPuNSgo71IEhcL2zmHzo8vYfhKgAJ/cq/xKrFe18VOKlslemiFYt /bpVV13emorU4+dh7X8LxwXg1IJdulYdfUGu8RdKpzqA3i5v74OViGOHyWKXLIAC3ibH 1IPJroGUfkirR47fl39VBGshrSgfZpxH0BxEY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :x-enigmail-version:content-type; b=m0vMjO/ggdrSjarSqxsA7g27rOldoPJhc4/pbCdII8SQyKEvujleN+YhW118rnzHzR YSRkR+pfmAL07zRgz0RF4Y971wAe45Y4hFDKE4mM56bmS1PQ+gT8yvdbQzBNIrPIiaUq JlteGGep6Qju7xivjRZzztyUFe9pdf0jsRvQ8= Received: by 10.211.168.4 with SMTP id v4mr2995885ebo.82.1250963071313; Sat, 22 Aug 2009 10:44:31 -0700 (PDT) Received: from ?192.168.1.100? ([212.225.192.125]) by mx.google.com with ESMTPS id 10sm3072041eyz.31.2009.08.22.10.44.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 22 Aug 2009 10:44:31 -0700 (PDT) Message-ID: <4A902E56.9000604@gmail.com> Date: Sat, 22 Aug 2009 19:43:50 +0200 From: Pablo Castellano User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: linux-media@vger.kernel.org CC: mchehab@infradead.org Subject: [PATCH] Add remote support to cph03x bttv card X-Enigmail-Version: 0.95.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello kernel developers. I found a bug report from an user in launchpad. I just copy it here. It includes patch. I don't own the necessary hardware to test it but the patch looks trivial. I'm not subscribed to this list, so please CC me. Thanks! Here is the text: """ remote control for my tv card doesnt work I have Askey CPH03x TV Capturer. When I load bttv module with "card=59" option which is proper for this tv card, I can watch tv with sound but my remote control doesnt work. There is no ir event in /proc/bus/input/device . When bttv module is loaded with "card=137" option remote control works very well. $ cat /proc/bus/input/devices ....... ........ : Bus=0001 Vendor=109e Product=0350 Version=0001 N: Name="bttv IR (card=137)" P: Phys=pci-0000:00:0d.0/ir0 S: Sysfs=/devices/pci0000:00/0000:00:0d.0/input/input144 U: Uniq= H: Handlers=kbd event6 B: EV=100003 B: KEY=2c0814 100004 0 0 0 4 2008000 2090 2001 1e0000 4400 0 ffc Unfortunately there is no sound. """ https://bugs.launchpad.net/ubuntu/+bug/239733 http://bugzilla.kernel.org/show_bug.cgi?id=11995 diff -Nurp linux-source-2.6.27/drivers/media/video/bt8xx.old/bttv-cards.c linux-source-2.6.27/drivers/media/video/bt8xx/bttv-cards.c --- linux-source-2.6.27/drivers/media/video/bt8xx.old/bttv-cards.c 2008-11-09 18:05:17.000000000 +0100 +++ linux-source-2.6.27/drivers/media/video/bt8xx/bttv-cards.c 2008-11-09 18:05:46.000000000 +0100 @@ -1362,6 +1362,7 @@ struct tvcard bttv_tvcards[] = { .tuner_type = TUNER_TEMIC_PAL, .tuner_addr = ADDR_UNSET, .radio_addr = ADDR_UNSET, + .has_remote = 1, }, /* ---- card 0x3c ---------------------------------- */ diff -Nurp linux-source-2.6.27/drivers/media/video/bt8xx.old/bttv-input.c linux-source-2.6.27/drivers/media/video/bt8xx/bttv-input.c --- linux-source-2.6.27/drivers/media/video/bt8xx.old/bttv-input.c 2008-11-09 18:05:17.000000000 +0100 +++ linux-source-2.6.27/drivers/media/video/bt8xx/bttv-input.c 2008-11-09 18:05:39.000000000 +0100 @@ -260,6 +260,7 @@ int bttv_input_init(struct bttv *btv) ir->mask_keyup = 0x008000; ir->polling = 50; // ms break; + case BTTV_BOARD_ASKEY_CPH03X: case BTTV_BOARD_CONCEPTRONIC_CTVFMI2: case BTTV_BOARD_CONTVFMI: ir_codes = ir_codes_pixelview;