From patchwork Sun Nov  8 12:32:50 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: =?utf-8?b?TsODwqltZXRoIE3Dg8KhcnRvbg==?=
 <nm127@freemail.hu>
X-Patchwork-Id: 58522
Received: from vger.kernel.org (vger.kernel.org [209.132.176.167])
	by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nA8CWtF5006386
	for <patchwork-media@patchwork.kernel.org>;
	Sun, 8 Nov 2009 12:32:55 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754426AbZKHMct (ORCPT
	<rfc822;patchwork-media@patchwork.kernel.org>);
	Sun, 8 Nov 2009 07:32:49 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754423AbZKHMct
	(ORCPT <rfc822;linux-media-outgoing>);
	Sun, 8 Nov 2009 07:32:49 -0500
Received: from mail02d.mail.t-online.hu ([84.2.42.7]:52836 "EHLO
	mail02d.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754324AbZKHMcs (ORCPT
	<rfc822; linux-media@vger.kernel.org>); Sun, 8 Nov 2009 07:32:48 -0500
Received: from [192.168.1.64] (dsl5402C46E.pool.t-online.hu [84.2.196.110])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail02d.mail.t-online.hu (Postfix) with ESMTPSA id 2E7467585E4;
	Sun,  8 Nov 2009 13:32:36 +0100 (CET)
Message-ID: <4AF6BA72.4070809@freemail.hu>
Date: Sun, 08 Nov 2009 13:32:50 +0100
From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= <nm127@freemail.hu>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU;
	rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16
MIME-Version: 1.0
To: Hans de Goede <hdegoede@redhat.com>,
	Jean-Francois Moine <moinejf@free.fr>,
	V4L Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH] v4l2-dbg: report fail reason to the user
X-DCC-mail.t-online.hu-Metrics: mail02d.mail.t-online.hu 32721; Body=3 Fuz1=3
	Fuz2=3
Sender: linux-media-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-media.vger.kernel.org>
X-Mailing-List: linux-media@vger.kernel.org


diff -r 19c0469c02c3 v4l2-apps/util/v4l2-dbg.cpp
--- a/v4l2-apps/util/v4l2-dbg.cpp	Sat Nov 07 15:51:01 2009 -0200
+++ b/v4l2-apps/util/v4l2-dbg.cpp	Sun Nov 08 14:13:52 2009 +0100
@@ -354,13 +354,14 @@
 {
 	int retVal;

-	if (!options[OptVerbose]) return ioctl(fd, request, parm);
 	retVal = ioctl(fd, request, parm);
-	printf("%s: ", name);
-	if (retVal < 0)
-		printf("failed: %s\n", strerror(errno));
-	else
-		printf("ok\n");
+	if (options[OptVerbose]) {
+		printf("%s: ", name);
+		if (retVal < 0)
+			printf("failed: %s\n", strerror(errno));
+		else
+			printf("ok\n");
+	}

 	return retVal;
 }
@@ -586,8 +587,9 @@

 				printf(" set to 0x%llx\n", set_reg.val);
 			} else {
-				printf("Failed to set register 0x%08llx value 0x%llx\n",
-					set_reg.reg, set_reg.val);
+				printf("Failed to set register 0x%08llx value 0x%llx: "
+					"%s\n",
+					set_reg.reg, set_reg.val, strerror(errno));
 			}
 			set_reg.reg++;
 		}