From patchwork Sun Jan 3 17:04:42 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roel Kluin X-Patchwork-Id: 70510 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id o03H1knf019961 for ; Sun, 3 Jan 2010 17:01:46 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753007Ab0ACRBR (ORCPT ); Sun, 3 Jan 2010 12:01:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752982Ab0ACRBQ (ORCPT ); Sun, 3 Jan 2010 12:01:16 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:50321 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752908Ab0ACRBP (ORCPT ); Sun, 3 Jan 2010 12:01:15 -0500 Received: by ewy19 with SMTP id 19so6564623ewy.21 for ; Sun, 03 Jan 2010 09:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=w9uCuxLSC7J3fQRogpdAlxjPcb1skZVRTV2SL+O2mjw=; b=rAwQBITpXJYHKTz+uoKBtPOlHQQ7n7L5rcTvbhAuQ6A6nRPq094Z+sLlEk4p6D0MeI sZ/Sap+DLwkdhmhIQdb7vHgZlxx1FvZkYDpMR4ChHtcg4oLFDATDkHllGKLguuh+Hvaj PrurEzDfx2wMv2Fd0pKQaQue5XiA7KAn9YMoE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=MlmQcp4gnRkRuaQ2awzt2QbVXjne6ELD6Ncvf6Bn25CozPwzO1rPctsUldbM44Ue5q TWzIuiz9meIjDr6cW8h9EBhvYZLNxz/m9z/opwJg8HtNz3qdFptr1eZBtVNOnBORJaei YeG6qcM2D61cWpwsGOppYH3NyyVBC7uBpBlD0= Received: by 10.216.88.71 with SMTP id z49mr886878wee.90.1262538073389; Sun, 03 Jan 2010 09:01:13 -0800 (PST) Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 5sm41664339eyf.6.2010.01.03.09.01.12 (version=SSLv3 cipher=RC4-MD5); Sun, 03 Jan 2010 09:01:12 -0800 (PST) Message-ID: <4B40CE2A.2090209@gmail.com> Date: Sun, 03 Jan 2010 18:04:42 +0100 From: Roel Kluin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 MIME-Version: 1.0 To: Mauro Carvalho Chehab , linux-media@vger.kernel.org, Andrew Morton , LKML Subject: [PATCH] V4L/DVB (12930): Wrong variable tested Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org diff --git a/drivers/media/video/saa7164/saa7164-api.c b/drivers/media/video/saa7164/saa7164-api.c index 6f094a9..1d487c1 100644 --- a/drivers/media/video/saa7164/saa7164-api.c +++ b/drivers/media/video/saa7164/saa7164-api.c @@ -523,7 +523,7 @@ int saa7164_api_i2c_write(struct saa7164_i2c *bus, u8 addr, u32 datalen, } reglen = saa7164_i2caddr_to_reglen(bus, addr); - if (unitid < 0) { + if (reglen < 0) { printk(KERN_ERR "%s() error, cannot translate regaddr to reglen\n", __func__);