From patchwork Wed Feb 3 19:48:05 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roel Kluin X-Patchwork-Id: 76786 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o13JfqhG009790 for ; Wed, 3 Feb 2010 19:41:53 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757618Ab0BCTlu (ORCPT ); Wed, 3 Feb 2010 14:41:50 -0500 Received: from ey-out-2122.google.com ([74.125.78.26]:57168 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753806Ab0BCTlt (ORCPT ); Wed, 3 Feb 2010 14:41:49 -0500 Received: by ey-out-2122.google.com with SMTP id d26so385457eyd.19 for ; Wed, 03 Feb 2010 11:41:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=shXUVXMNtKAC4fA8I+82N6pMfte2JYyxhEsj3B/ANGo=; b=M83nBUdFMQieO45okcQL8q5YjljMz6IKaMQ/hgz/18t9F9SgvMJqLgPzvdOhGgRofh WZbDNkCvgIwAy6Ae/hcHX8XF4Szo/l8c5+jwTGwgmrJg/ZWpTsRl0szw1fj61zCnbiNI gY6QovK9DyxmcGS9g/pc5hpTps+TTH6inCUe4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=MKv6sAVFIralqoHfeIV6voEfSzVOtZ4NNuAL718wIcEDkIe7ooDaU2xCuiJ22DYGAE aRHVM6bCyLZAvxgIkPBMVVDd2NUgCbu3mhiliF/g8Lk2JHA6aEsuj05+qT7+gLt60iJT 7qk4j3zP0NrbCsIC97LFEgkAru695n0UuW/V8= Received: by 10.213.38.5 with SMTP id z5mr2610732ebd.8.1265226107386; Wed, 03 Feb 2010 11:41:47 -0800 (PST) Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 10sm143253eyd.21.2010.02.03.11.41.46 (version=SSLv3 cipher=RC4-MD5); Wed, 03 Feb 2010 11:41:46 -0800 (PST) Message-ID: <4B69D2F5.2050100@gmail.com> Date: Wed, 03 Feb 2010 20:48:05 +0100 From: Roel Kluin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 MIME-Version: 1.0 To: Mauro Carvalho Chehab , tobias.lorenz@gmx.net, linux-media@vger.kernel.org, Andrew Morton , LKML Subject: [PATCH] radio-si470x-common: -EINVAL overwritten in si470x_vidioc_s_tuner() Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 03 Feb 2010 19:41:53 +0000 (UTC) diff --git a/drivers/media/radio/si470x/radio-si470x-common.c b/drivers/media/radio/si470x/radio-si470x-common.c index 4da0f15..65b4a92 100644 --- a/drivers/media/radio/si470x/radio-si470x-common.c +++ b/drivers/media/radio/si470x/radio-si470x-common.c @@ -748,12 +748,13 @@ static int si470x_vidioc_s_tuner(struct file *file, void *priv, struct v4l2_tuner *tuner) { struct si470x_device *radio = video_drvdata(file); - int retval = -EINVAL; + int retval; /* safety checks */ retval = si470x_disconnect_check(radio); if (retval) goto done; + retval = -EINVAL; if (tuner->index != 0) goto done;