From patchwork Tue Apr 20 17:22:31 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Maraschini X-Patchwork-Id: 93688 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o3KHKXZB004988 for ; Tue, 20 Apr 2010 17:27:39 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754771Ab0DTRWy (ORCPT ); Tue, 20 Apr 2010 13:22:54 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:46995 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754401Ab0DTRWx (ORCPT ); Tue, 20 Apr 2010 13:22:53 -0400 Received: by vws5 with SMTP id 5so3134317vws.19 for ; Tue, 20 Apr 2010 10:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:content-type :content-transfer-encoding; bh=ZJFxVznwcafQEPDpUF3NLWe1Ssze6zLCR2n0iMkYlkg=; b=PGoX9xeETZtssH/+IaXxdaTQTh8dU6M23JP/BHatpNk/RduTBQvey/1hf+SO0z3OAt Gqk9Kd6Vbht5hYATg/QZbHaG8uu/EiGfGATSUuRDqWclLTR4H1/WyXqy5CumZm1m59Y/ yuw7yeG1marMRwPjaTMy9b9g4k1XwY3YNiCDc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=N3kUbuIODglsO3CQCagJvBx8I8Cj9miF3E2kL90HqpJqwNSWhdO4BU67B6BLE6l+xw 4JIFttKk1hmJR2dmTc1TX38HquFQjapKvY24JyFBHWS+uGtpHpR/6A8opE/vxxRi72vH DOobuWhVrKKfwetCBQdY+E1R7uxsjMTpXI1Vo= Received: by 10.220.61.142 with SMTP id t14mr4869510vch.11.1271784172681; Tue, 20 Apr 2010 10:22:52 -0700 (PDT) Received: from [192.168.10.175] ([200.175.93.74]) by mx.google.com with ESMTPS id s9sm16716996vcr.15.2010.04.20.10.22.50 (version=SSLv3 cipher=RC4-MD5); Tue, 20 Apr 2010 10:22:51 -0700 (PDT) Message-ID: <4BCDE2D7.3020800@gmail.com> Date: Tue, 20 Apr 2010 14:22:31 -0300 From: Ricardo Maraschini User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Thunderbird/3.0.3 MIME-Version: 1.0 To: linux-media@vger.kernel.org CC: dougsland@gmail.com Subject: [PATCH] cx25821-video-upstream.c: Added severity to printk calls Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 20 Apr 2010 17:28:15 +0000 (UTC) --- a/linux/drivers/staging/cx25821/cx25821-video-upstream.c Sun Apr 18 11:12:11 2010 -0300 +++ b/linux/drivers/staging/cx25821/cx25821-video-upstream.c Tue Apr 20 11:21:17 2010 -0300 @@ -257,7 +257,7 @@ if (!dev->_is_running) { printk - ("cx25821: No video file is currently running so return!\n"); + (KERN_INFO "cx25821: No video file is currently running so return!\n"); return; } /* Disable RISC interrupts */ @@ -345,19 +345,19 @@ if (IS_ERR(myfile)) { const int open_errno = -PTR_ERR(myfile); - printk("%s(): ERROR opening file(%s) with errno = %d!\n", + printk(KERN_ERR "%s(): ERROR opening file(%s) with errno = %d!\n", __func__, dev->_filename, open_errno); return PTR_ERR(myfile); } else { if (!(myfile->f_op)) { - printk("%s: File has no file operations registered!", + printk(KERN_ERR "%s: File has no file operations registered!", __func__); filp_close(myfile, NULL); return -EIO; } if (!myfile->f_op->read) { - printk("%s: File has no READ operations registered!", + printk(KERN_ERR "%s: File has no READ operations registered!", __func__); filp_close(myfile, NULL); return -EIO; @@ -410,7 +410,7 @@ container_of(work, struct cx25821_dev, _irq_work_entry); if (!dev) { - printk("ERROR %s(): since container_of(work_struct) FAILED!\n", + printk(KERN_ERR "ERROR %s(): since container_of(work_struct) FAILED!\n", __func__); return; } @@ -436,12 +436,12 @@ if (IS_ERR(myfile)) { const int open_errno = -PTR_ERR(myfile); - printk("%s(): ERROR opening file(%s) with errno = %d!\n", + printk(KERN_ERR "%s(): ERROR opening file(%s) with errno = %d!\n", __func__, dev->_filename, open_errno); return PTR_ERR(myfile); } else { if (!(myfile->f_op)) { - printk("%s: File has no file operations registered!", + printk(KERN_ERR "%s: File has no file operations registered!", __func__); filp_close(myfile, NULL); return -EIO; @@ -449,7 +449,7 @@ if (!myfile->f_op->read) { printk - ("%s: File has no READ operations registered! Returning.", + (KERN_ERR "%s: File has no READ operations registered! Returning.", __func__); filp_close(myfile, NULL); return -EIO; @@ -525,7 +525,7 @@ if (!dev->_dma_virt_addr) { printk - ("cx25821: FAILED to allocate memory for Risc buffer! Returning.\n"); + (KERN_ERR "cx25821: FAILED to allocate memory for Risc buffer! Returning.\n"); return -ENOMEM; } @@ -546,7 +546,7 @@ if (!dev->_data_buf_virt_addr) { printk - ("cx25821: FAILED to allocate memory for data buffer! Returning.\n"); + (KERN_ERR "cx25821: FAILED to allocate memory for data buffer! Returning.\n"); return -ENOMEM; } @@ -641,20 +641,20 @@ } else { if (status & FLD_VID_SRC_UF) printk - ("%s: Video Received Underflow Error Interrupt!\n", + (KERN_ERR "%s: Video Received Underflow Error Interrupt!\n", __func__); if (status & FLD_VID_SRC_SYNC) - printk("%s: Video Received Sync Error Interrupt!\n", + printk(KERN_ERR "%s: Video Received Sync Error Interrupt!\n", __func__); if (status & FLD_VID_SRC_OPC_ERR) - printk("%s: Video Received OpCode Error Interrupt!\n", + printk(KERN_ERR "%s: Video Received OpCode Error Interrupt!\n", __func__); } if (dev->_file_status == END_OF_FILE) { - printk("cx25821: EOF Channel 1 Framecount = %d\n", + printk(KERN_ERR "cx25821: EOF Channel 1 Framecount = %d\n", dev->_frame_count); return -1; } @@ -794,7 +794,7 @@ int str_length = 0; if (dev->_is_running) { - printk("Video Channel is still running so return!\n"); + printk(KERN_INFO "Video Channel is still running so return!\n"); return 0; } @@ -806,7 +806,7 @@ if (!dev->_irq_queues) { printk - ("cx25821: create_singlethread_workqueue() for Video FAILED!\n"); + (KERN_ERR "cx25821: create_singlethread_workqueue() for Video FAILED!\n"); return -ENOMEM; } /* 656/VIP SRC Upstream Channel I & J and 7 - Host Bus Interface for