| Message ID | 4ea494cf-134e-4380-aea1-4c166a626561@freebox.fr (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for qcom msm8998-venus (HW vdec / venc) | expand |
On 29/04/2024 17:15, Marc Gonzalez wrote: > Add YAML binding for Qualcomm MSM8998 Venus HW video encode and decode. > (Based on qcom,msm8996-venus.yaml) > > Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> > --- > Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml | 155 ++++++++++++++++++++++++++++ > 1 file changed, 155 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml > new file mode 100644 > index 0000000000000..86a20954cb354 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml > @@ -0,0 +1,155 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,msm8998-venus.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm MSM8998 Venus video encode and decode accelerators > + > +maintainers: > + - Stanimir Varbanov <stanimir.varbanov@linaro.org> You should list yourself as maintaining a file you add upstream, plus I'm pretty sure that's not Stan's current email address. However, looking at this I think you should just add a new compat to Documentation/devicetree/bindings/media/qcom,msm8996-venus.yaml since the rest of the file is 1:1 --- bod
On 29/04/2024 18:15, Marc Gonzalez wrote: > Add YAML binding for Qualcomm MSM8998 Venus HW video encode and decode. > (Based on qcom,msm8996-venus.yaml) > > Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> > --- > Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml | 155 ++++++++++++++++++++++++++++ > 1 file changed, 155 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml > new file mode 100644 > index 0000000000000..86a20954cb354 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml > @@ -0,0 +1,155 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,msm8998-venus.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm MSM8998 Venus video encode and decode accelerators > + > +maintainers: > + - Stanimir Varbanov <stanimir.varbanov@linaro.org> > + > +description: | Do not need '|' unless you need to preserve formatting. > + The Venus IP is a video encode and decode accelerator present > + on Qualcomm platforms > + > +allOf: > + - $ref: qcom,venus-common.yaml# > + > +properties: > + compatible: > + const: qcom,msm8998-venus > + > + power-domains: > + maxItems: 1 > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: core > + - const: iface > + - const: bus > + - const: mbus > + > + interconnects: > + maxItems: 2 > + > + interconnect-names: > + items: > + - const: video-mem > + - const: cpu-cfg > + > + iommus: > + maxItems: 20 > + > + video-decoder: > + type: object > + > + properties: > + compatible: > + const: venus-decoder > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: core > + > + power-domains: > + maxItems: 1 > + > + required: > + - compatible > + - clocks > + - clock-names > + - power-domains > + > + additionalProperties: false > + > + video-encoder: > + type: object > + > + properties: > + compatible: > + const: venus-encoder > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: core > + > + power-domains: > + maxItems: 1 > + > + required: > + - compatible > + - clocks > + - clock-names > + - power-domains > + > + additionalProperties: false In nested blocks, put it after the type:object, for readability. > + Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 30.04.2024 9:54 AM, Krzysztof Kozlowski wrote: > On 29/04/2024 18:15, Marc Gonzalez wrote: >> Add YAML binding for Qualcomm MSM8998 Venus HW video encode and decode. >> (Based on qcom,msm8996-venus.yaml) >> >> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> >> --- [...] >> + >> + required: >> + - compatible >> + - clocks >> + - clock-names >> + - power-domains >> + >> + additionalProperties: false > > In nested blocks, put it after the type:object, for readability. > >> + > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> https://lore.kernel.org/linux-arm-msm/ba40de82-b308-67b1-5751-bb2d95f2b8a5@linaro.org/ We've since established that the video-encoder/decoder subnodes are bogus Konrad
diff --git a/Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml new file mode 100644 index 0000000000000..86a20954cb354 --- /dev/null +++ b/Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml @@ -0,0 +1,155 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/qcom,msm8998-venus.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm MSM8998 Venus video encode and decode accelerators + +maintainers: + - Stanimir Varbanov <stanimir.varbanov@linaro.org> + +description: | + The Venus IP is a video encode and decode accelerator present + on Qualcomm platforms + +allOf: + - $ref: qcom,venus-common.yaml# + +properties: + compatible: + const: qcom,msm8998-venus + + power-domains: + maxItems: 1 + + clocks: + maxItems: 4 + + clock-names: + items: + - const: core + - const: iface + - const: bus + - const: mbus + + interconnects: + maxItems: 2 + + interconnect-names: + items: + - const: video-mem + - const: cpu-cfg + + iommus: + maxItems: 20 + + video-decoder: + type: object + + properties: + compatible: + const: venus-decoder + + clocks: + maxItems: 1 + + clock-names: + items: + - const: core + + power-domains: + maxItems: 1 + + required: + - compatible + - clocks + - clock-names + - power-domains + + additionalProperties: false + + video-encoder: + type: object + + properties: + compatible: + const: venus-encoder + + clocks: + maxItems: 1 + + clock-names: + items: + - const: core + + power-domains: + maxItems: 1 + + required: + - compatible + - clocks + - clock-names + - power-domains + + additionalProperties: false + +required: + - compatible + - iommus + - video-decoder + - video-encoder + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/qcom,mmcc-msm8998.h> + + video-codec@cc00000 { + compatible = "qcom,msm8998-venus"; + reg = <0x0cc00000 0xff000>; + interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&mmcc VIDEO_TOP_GDSC>; + clocks = <&mmcc VIDEO_CORE_CLK>, + <&mmcc VIDEO_AHB_CLK>, + <&mmcc VIDEO_AXI_CLK>, + <&mmcc VIDEO_MAXI_CLK>; + clock-names = "core", "iface", "bus", "mbus"; + iommus = <&mmss_smmu 0x400>, + <&mmss_smmu 0x401>, + <&mmss_smmu 0x40a>, + <&mmss_smmu 0x407>, + <&mmss_smmu 0x40e>, + <&mmss_smmu 0x40f>, + <&mmss_smmu 0x408>, + <&mmss_smmu 0x409>, + <&mmss_smmu 0x40b>, + <&mmss_smmu 0x40c>, + <&mmss_smmu 0x40d>, + <&mmss_smmu 0x410>, + <&mmss_smmu 0x421>, + <&mmss_smmu 0x428>, + <&mmss_smmu 0x429>, + <&mmss_smmu 0x42b>, + <&mmss_smmu 0x42c>, + <&mmss_smmu 0x42d>, + <&mmss_smmu 0x411>, + <&mmss_smmu 0x431>; + memory-region = <&venus_mem>; + + video-decoder { + compatible = "venus-decoder"; + clocks = <&mmcc VIDEO_SUBCORE0_CLK>; + clock-names = "core"; + power-domains = <&mmcc VIDEO_SUBCORE0_GDSC>; + }; + + video-encoder { + compatible = "venus-encoder"; + clocks = <&mmcc VIDEO_SUBCORE1_CLK>; + clock-names = "core"; + power-domains = <&mmcc VIDEO_SUBCORE1_GDSC>; + }; + };
Add YAML binding for Qualcomm MSM8998 Venus HW video encode and decode. (Based on qcom,msm8996-venus.yaml) Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr> --- Documentation/devicetree/bindings/media/qcom,msm8998-venus.yaml | 155 ++++++++++++++++++++++++++++ 1 file changed, 155 insertions(+)