From patchwork Thu Aug 30 11:27:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Thomson X-Patchwork-Id: 1387401 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 2001BDF264 for ; Thu, 30 Aug 2012 11:27:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752533Ab2H3L1Y (ORCPT ); Thu, 30 Aug 2012 07:27:24 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:41622 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627Ab2H3L1X (ORCPT ); Thu, 30 Aug 2012 07:27:23 -0400 Received: by lbbgj3 with SMTP id gj3so414366lbb.19 for ; Thu, 30 Aug 2012 04:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:disposition-notification-to:date:from:user-agent :mime-version:to:subject:content-type:content-transfer-encoding; bh=CLpvHD/ZQOTtlYXJy9dL0i1+vpNKvybMwE4McoQWJlo=; b=oojdo1sbW6wla2Gd/RFShwR7X+h6vnoTXIKOljtry1H9MElb42OwyQ6e9gSEB/KHMD NbA/lklCBALvlZyber+YUirDglY0MfVDFucKOVp3uyxMy8mM+Mqayx1S5Ylh5FHr8xeg sXVzv+OjRiV3t/jMgMD4c7BsthGTQxfhrNxGZceRaYi8qC/5VHcXy5Sokp+F/MzhOS47 1CmuoN5BM2pFFQ7KRkyFe4QrimCXaZy409d6FBmJqHEyWnXwdTB6zCMOYXAZCbLKrqk1 ng/2GYXko92QoOVyy5EmduDsMPh4mri7zRCQ7DMXzGviec9LGH8nu+iLeDclU8Hs+rxS 9ydA== Received: by 10.152.130.3 with SMTP id oa3mr2986355lab.27.1346326042228; Thu, 30 Aug 2012 04:27:22 -0700 (PDT) Received: from [192.168.1.100] (c83-252-237-27.bredband.comhem.se. [83.252.237.27]) by mx.google.com with ESMTPS id fv16sm1498028lab.9.2012.08.30.04.27.20 (version=SSLv3 cipher=OTHER); Thu, 30 Aug 2012 04:27:21 -0700 (PDT) Message-ID: <503F4E19.1050700@gmail.com> Date: Thu, 30 Aug 2012 13:27:21 +0200 From: Anders Thomson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120808 Thunderbird/10.0.6 MIME-Version: 1.0 To: "linux-media@vger.kernel.org" Subject: tda8290 regression fix Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, Ever since 2.6.26 or so (where there was a code reorg) I had to carry this patch. Without it the received signal is noisy, and the card worked fine prior to the code reorg. This patch is a hack, mostly as a result of my inability to follow the code paths (and bisect failing). I'd be more than willing to test whatever the proper patch might be prior to any mainlining. Thanks, /Anders $ cat /TV_CARD.diff fe->ops.tuner_ops.init(fe); --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/common/tuners/tda8290.c b/drivers/media/common/tuners/tda8290.c index 064d14c..498cc7b 100644 --- a/drivers/media/common/tuners/tda8290.c +++ b/drivers/media/common/tuners/tda8290.c @@ -635,7 +635,11 @@ static int tda829x_find_tuner(struct dvb_frontend *fe) dvb_attach(tda827x_attach, fe, priv->tda827x_addr, priv->i2c_props.adap, &priv->cfg); + tuner_info("ANDERS: setting switch_addr. was 0x%02x, new 0x%02x\n",priv->cfg.switch_addr,priv->i2c_props.addr); priv->cfg.switch_addr = priv->i2c_props.addr; + priv->cfg.switch_addr = 0xc2 / 2; + tuner_info("ANDERS: new 0x%02x\n",priv->cfg.switch_addr); + } if (fe->ops.tuner_ops.init)