diff mbox

[-next] media/platform/marvell-ccic: fix cafe_ccic build error

Message ID 52729C60.6000408@infradead.org (mailing list archive)
State New, archived
Headers show

Commit Message

Randy Dunlap Oct. 31, 2013, 6:07 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

The cafe_ccic driver (the mcam-core.c part of it) uses dma_sg
interfaces so it needs to select VIDEOBUF2_DMA_SG to prevent
build errors.

drivers/built-in.o: In function `mcam_v4l_open':
mcam-core.c:(.text+0x14643e): undefined reference to `vb2_dma_sg_memops'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
---
 drivers/media/platform/marvell-ccic/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jonathan Corbet Oct. 31, 2013, 9:09 p.m. UTC | #1 
On Thu, 31 Oct 2013 11:07:28 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> The cafe_ccic driver (the mcam-core.c part of it) uses dma_sg
> interfaces so it needs to select VIDEOBUF2_DMA_SG to prevent
> build errors.

Geert sent a patch too a little while back.

BUT, this shouldn't be happening.  Could you send a .config file that
evokes this failure?  All of the s/g stuff is ifdeffed out if
VIDEOBUF2_DMA_SG isn't enabled...or it used to be...  I'd rather figure
out what's going on and not drag the s/g stuff into OLPC XO builds, where
memory is tight and there's no use for it.

(Sorry, I'm *way* behind on everything...)

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Randy Dunlap Oct. 31, 2013, 9:46 p.m. UTC | #2 
On 10/31/13 14:09, Jonathan Corbet wrote:
> On Thu, 31 Oct 2013 11:07:28 -0700
> Randy Dunlap <rdunlap@infradead.org> wrote:
> 
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> The cafe_ccic driver (the mcam-core.c part of it) uses dma_sg
>> interfaces so it needs to select VIDEOBUF2_DMA_SG to prevent
>> build errors.
> 
> Geert sent a patch too a little while back.
> 
> BUT, this shouldn't be happening.  Could you send a .config file that
> evokes this failure?  All of the s/g stuff is ifdeffed out if
> VIDEOBUF2_DMA_SG isn't enabled...or it used to be...  I'd rather figure
> out what's going on and not drag the s/g stuff into OLPC XO builds, where
> memory is tight and there's no use for it.

Sure, the randconfig file is attached.

> (Sorry, I'm *way* behind on everything...)

Thanks.
diff mbox

Patch

--- linux-next-20131031.orig/drivers/media/platform/marvell-ccic/Kconfig
+++ linux-next-20131031/drivers/media/platform/marvell-ccic/Kconfig
@@ -4,6 +4,7 @@  config VIDEO_CAFE_CCIC
 	select VIDEO_OV7670
 	select VIDEOBUF2_VMALLOC
 	select VIDEOBUF2_DMA_CONTIG
+	select VIDEOBUF2_DMA_SG
 	---help---
 	  This is a video4linux2 driver for the Marvell 88ALP01 integrated
 	  CMOS camera controller.  This is the controller found on first-