From patchwork Thu Oct 31 18:07:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 3121691 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 52B07BEEB2 for ; Thu, 31 Oct 2013 18:07:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3B6E320414 for ; Thu, 31 Oct 2013 18:07:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35562203F4 for ; Thu, 31 Oct 2013 18:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754897Ab3JaSHf (ORCPT ); Thu, 31 Oct 2013 14:07:35 -0400 Received: from merlin.infradead.org ([205.233.59.134]:49336 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754599Ab3JaSHe (ORCPT ); Thu, 31 Oct 2013 14:07:34 -0400 Received: from static-50-53-39-157.bvtn.or.frontiernet.net ([50.53.39.157] helo=dragon.site) by merlin.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1VbweY-0007cQ-Di; Thu, 31 Oct 2013 18:07:30 +0000 Message-ID: <52729C60.6000408@infradead.org> Date: Thu, 31 Oct 2013 11:07:28 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Stephen Rothwell , linux-next@vger.kernel.org CC: linux-kernel@vger.kernel.org, Jonathan Corbet , Hans Verkuil , linux-media , Mauro Carvalho Chehab Subject: [PATCH -next] media/platform/marvell-ccic: fix cafe_ccic build error References: <20131031210027.cb3604b9589e0b7a1599dbd2@canb.auug.org.au> In-Reply-To: <20131031210027.cb3604b9589e0b7a1599dbd2@canb.auug.org.au> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Randy Dunlap The cafe_ccic driver (the mcam-core.c part of it) uses dma_sg interfaces so it needs to select VIDEOBUF2_DMA_SG to prevent build errors. drivers/built-in.o: In function `mcam_v4l_open': mcam-core.c:(.text+0x14643e): undefined reference to `vb2_dma_sg_memops' Signed-off-by: Randy Dunlap Cc: Jonathan Corbet Cc: Hans Verkuil --- drivers/media/platform/marvell-ccic/Kconfig | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-next-20131031.orig/drivers/media/platform/marvell-ccic/Kconfig +++ linux-next-20131031/drivers/media/platform/marvell-ccic/Kconfig @@ -4,6 +4,7 @@ config VIDEO_CAFE_CCIC select VIDEO_OV7670 select VIDEOBUF2_VMALLOC select VIDEOBUF2_DMA_CONTIG + select VIDEOBUF2_DMA_SG ---help--- This is a video4linux2 driver for the Marvell 88ALP01 integrated CMOS camera controller. This is the controller found on first-