diff mbox series

[RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera

Message ID 527C2E71-12E2-45D1-9B50-5A413B6920A1@live.com (mailing list archive)
State New, archived
Headers show
Series [RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera | expand

Commit Message

Aditya Garg Jan. 26, 2022, 10:37 a.m. UTC 
From: Paul Pawlowski <paul@mrarm.io>

Adds the requisite device id to support detection of the Apple FaceTime
HD webcam exposed over the T2 BCE VHCI interface.

Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
Signed-off-by: Paul Pawlowski <paul@mrarm.io>
Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
Signed-off-by: Aditya Garg <gargaditya08@live.com>
---
 drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Aditya Garg Jan. 31, 2022, 9:12 a.m. UTC | #1 
Hi Maintainers

I sent this patch on 12.01.22 and then resent it on 26.01.22. I still haven't received a reply yet. Maybe I am not sending the mail to the correct maintainer? I request someone to reply cause no reply seems to create a confusion.

Linus, I am sending this mail to you too, since you are the ultimate maintainer.

Regards
Aditya
> On 26-Jan-2022, at 4:07 PM, Aditya Garg <gargaditya08@live.com> wrote:
> 
> From: Paul Pawlowski <paul@mrarm.io>
> 
> Adds the requisite device id to support detection of the Apple FaceTime
> HD webcam exposed over the T2 BCE VHCI interface.
> 
> Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
> Signed-off-by: Paul Pawlowski <paul@mrarm.io>
> Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 7c007426e..88dc9e7aa 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> 	  .bInterfaceProtocol	= 0,
> 	  .driver_info		= UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> 					| UVC_QUIRK_BUILTIN_ISIGHT) },
> +	/* Apple FaceTime HD Camera (Built-In) */
> +	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> +				| USB_DEVICE_ID_MATCH_INT_INFO,
> +	  .idVendor		= 0x05ac,
> +	  .idProduct		= 0x8514,
> +	  .bInterfaceClass	= USB_CLASS_VIDEO,
> +	  .bInterfaceSubClass	= 1,
> +	  .bInterfaceProtocol	= 0,
> +	  .driver_info		= (kernel_ulong_t)&uvc_quirk_probe_def },
> 	/* Apple Built-In iSight via iBridge */
> 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> 				| USB_DEVICE_ID_MATCH_INT_INFO,
> -- 
> 2.25.1
> 
>
Sergey Senozhatsky Feb. 2, 2022, 3:41 a.m. UTC | #2 
On (22/01/31 09:12), Aditya Garg wrote:
> > On 26-Jan-2022, at 4:07 PM, Aditya Garg <gargaditya08@live.com> wrote:
> > 
> > From: Paul Pawlowski <paul@mrarm.io>
> > 
> > Adds the requisite device id to support detection of the Apple FaceTime
> > HD webcam exposed over the T2 BCE VHCI interface.
> > 
> > Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
> > Signed-off-by: Paul Pawlowski <paul@mrarm.io>
> > Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
> > Signed-off-by: Aditya Garg <gargaditya08@live.com>

I'm not the maintainer, but the patch looks OK to me
FWIW
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>


Laurent, Ricardo, any thoughts?


> > drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> > 
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index 7c007426e..88dc9e7aa 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> > 	  .bInterfaceProtocol	= 0,
> > 	  .driver_info		= UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> > 					| UVC_QUIRK_BUILTIN_ISIGHT) },
> > +	/* Apple FaceTime HD Camera (Built-In) */
> > +	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> > +				| USB_DEVICE_ID_MATCH_INT_INFO,
> > +	  .idVendor		= 0x05ac,
> > +	  .idProduct		= 0x8514,
> > +	  .bInterfaceClass	= USB_CLASS_VIDEO,
> > +	  .bInterfaceSubClass	= 1,
> > +	  .bInterfaceProtocol	= 0,
> > +	  .driver_info		= (kernel_ulong_t)&uvc_quirk_probe_def },
> > 	/* Apple Built-In iSight via iBridge */
> > 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> > 				| USB_DEVICE_ID_MATCH_INT_INFO,
Laurent Pinchart Feb. 2, 2022, 6:37 a.m. UTC | #3 
Hi Aditya,

Thank you for the patch, and sorry for the late reply.

On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote:
> From: Paul Pawlowski <paul@mrarm.io>
> 
> Adds the requisite device id to support detection of the Apple FaceTime
> HD webcam exposed over the T2 BCE VHCI interface.
> 
> Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
> Signed-off-by: Paul Pawlowski <paul@mrarm.io>
> Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 7c007426e..88dc9e7aa 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
>  	  .bInterfaceProtocol	= 0,
>  	  .driver_info		= UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
>  					| UVC_QUIRK_BUILTIN_ISIGHT) },
> +	/* Apple FaceTime HD Camera (Built-In) */
> +	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> +				| USB_DEVICE_ID_MATCH_INT_INFO,
> +	  .idVendor		= 0x05ac,
> +	  .idProduct		= 0x8514,
> +	  .bInterfaceClass	= USB_CLASS_VIDEO,
> +	  .bInterfaceSubClass	= 1,
> +	  .bInterfaceProtocol	= 0,
> +	  .driver_info		= (kernel_ulong_t)&uvc_quirk_probe_def },

Have you tested that the device doesn't work without this quirk ?

>  	/* Apple Built-In iSight via iBridge */
>  	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
>  				| USB_DEVICE_ID_MATCH_INT_INFO,
Aditya Garg Feb. 2, 2022, 7:08 a.m. UTC | #4 
Hi Laurent

> On 02-Feb-2022, at 12:07 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> 
> Hi Aditya,
> 
> Thank you for the patch, and sorry for the late reply.
> 
> On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote:
>> From: Paul Pawlowski <paul@mrarm.io>
>> 
>> Adds the requisite device id to support detection of the Apple FaceTime
>> HD webcam exposed over the T2 BCE VHCI interface.
>> 
>> Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
>> Signed-off-by: Paul Pawlowski <paul@mrarm.io>
>> Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
>> Signed-off-by: Aditya Garg <gargaditya08@live.com>
>> ---
>> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>> 
>> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
>> index 7c007426e..88dc9e7aa 100644
>> --- a/drivers/media/usb/uvc/uvc_driver.c
>> +++ b/drivers/media/usb/uvc/uvc_driver.c
>> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
>> 	  .bInterfaceProtocol	= 0,
>> 	  .driver_info		= UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
>> 					| UVC_QUIRK_BUILTIN_ISIGHT) },
>> +	/* Apple FaceTime HD Camera (Built-In) */
>> +	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
>> +				| USB_DEVICE_ID_MATCH_INT_INFO,
>> +	  .idVendor		= 0x05ac,
>> +	  .idProduct		= 0x8514,
>> +	  .bInterfaceClass	= USB_CLASS_VIDEO,
>> +	  .bInterfaceSubClass	= 1,
>> +	  .bInterfaceProtocol	= 0,
>> +	  .driver_info		= (kernel_ulong_t)&uvc_quirk_probe_def },
> 
> Have you tested that the device doesn't work without this quirk ?
uvcvideo 1-2:1.1: Failed to query (129) UVC probe control : -110 (exp. 48).
uvcvideo 1-2:1.1: Failed to initialize the device (-5).

These errors are encountered without this patch
> 
>> 	/* Apple Built-In iSight via iBridge */
>> 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
>> 				| USB_DEVICE_ID_MATCH_INT_INFO,
> 
> -- 
> Regards,
> 
> Laurent Pinchart
Laurent Pinchart Feb. 2, 2022, 11:59 p.m. UTC | #5 
Hi Aditya,

On Wed, Feb 02, 2022 at 07:08:21AM +0000, Aditya Garg wrote:
> > On 02-Feb-2022, at 12:07 PM, Laurent Pinchart wrote:
> > On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote:
> >> From: Paul Pawlowski <paul@mrarm.io>
> >> 
> >> Adds the requisite device id to support detection of the Apple FaceTime
> >> HD webcam exposed over the T2 BCE VHCI interface.
> >> 
> >> Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
> >> Signed-off-by: Paul Pawlowski <paul@mrarm.io>
> >> Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
> >> Signed-off-by: Aditya Garg <gargaditya08@live.com>
> >> ---
> >> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> >> 1 file changed, 9 insertions(+)
> >> 
> >> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> >> index 7c007426e..88dc9e7aa 100644
> >> --- a/drivers/media/usb/uvc/uvc_driver.c
> >> +++ b/drivers/media/usb/uvc/uvc_driver.c
> >> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> >> 	  .bInterfaceProtocol	= 0,
> >> 	  .driver_info		= UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> >> 					| UVC_QUIRK_BUILTIN_ISIGHT) },
> >> +	/* Apple FaceTime HD Camera (Built-In) */
> >> +	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> >> +				| USB_DEVICE_ID_MATCH_INT_INFO,
> >> +	  .idVendor		= 0x05ac,
> >> +	  .idProduct		= 0x8514,
> >> +	  .bInterfaceClass	= USB_CLASS_VIDEO,
> >> +	  .bInterfaceSubClass	= 1,
> >> +	  .bInterfaceProtocol	= 0,
> >> +	  .driver_info		= (kernel_ulong_t)&uvc_quirk_probe_def },
> > 
> > Have you tested that the device doesn't work without this quirk ?
>
> uvcvideo 1-2:1.1: Failed to query (129) UVC probe control : -110 (exp. 48).
> uvcvideo 1-2:1.1: Failed to initialize the device (-5).
> 
> These errors are encountered without this patch

Thank you for the confirmation.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> >> 	/* Apple Built-In iSight via iBridge */
> >> 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> >> 				| USB_DEVICE_ID_MATCH_INT_INFO,
Aditya Garg Feb. 3, 2022, 12:51 p.m. UTC | #6 
> On 03-Feb-2022, at 5:29 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> 
> Hi Aditya,
> 
> On Wed, Feb 02, 2022 at 07:08:21AM +0000, Aditya Garg wrote:
>>> On 02-Feb-2022, at 12:07 PM, Laurent Pinchart wrote:
>>> On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote:
>>>> From: Paul Pawlowski <paul@mrarm.io>
>>>> 
>>>> Adds the requisite device id to support detection of the Apple FaceTime
>>>> HD webcam exposed over the T2 BCE VHCI interface.
>>>> 
>>>> Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
>>>> Signed-off-by: Paul Pawlowski <paul@mrarm.io>
>>>> Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
>>>> Signed-off-by: Aditya Garg <gargaditya08@live.com>
>>>> ---
>>>> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
>>>> 1 file changed, 9 insertions(+)
>>>> 
>>>> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
>>>> index 7c007426e..88dc9e7aa 100644
>>>> --- a/drivers/media/usb/uvc/uvc_driver.c
>>>> +++ b/drivers/media/usb/uvc/uvc_driver.c
>>>> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
>>>> 	  .bInterfaceProtocol	= 0,
>>>> 	  .driver_info		= UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
>>>> 					| UVC_QUIRK_BUILTIN_ISIGHT) },
>>>> +	/* Apple FaceTime HD Camera (Built-In) */
>>>> +	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
>>>> +				| USB_DEVICE_ID_MATCH_INT_INFO,
>>>> +	  .idVendor		= 0x05ac,
>>>> +	  .idProduct		= 0x8514,
>>>> +	  .bInterfaceClass	= USB_CLASS_VIDEO,
>>>> +	  .bInterfaceSubClass	= 1,
>>>> +	  .bInterfaceProtocol	= 0,
>>>> +	  .driver_info		= (kernel_ulong_t)&uvc_quirk_probe_def },
>>> 
>>> Have you tested that the device doesn't work without this quirk ?
>> 
>> uvcvideo 1-2:1.1: Failed to query (129) UVC probe control : -110 (exp. 48).
>> uvcvideo 1-2:1.1: Failed to initialize the device (-5).
>> 
>> These errors are encountered without this patch
> 
> Thank you for the confirmation.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> and applied to my tree.
Thanks !
> 
>>>> 	/* Apple Built-In iSight via iBridge */
>>>> 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
>>>> 				| USB_DEVICE_ID_MATCH_INT_INFO,
> 
> -- 
> Regards,
> 
> Laurent Pinchart
diff mbox series

Patch

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 7c007426e..88dc9e7aa 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2848,6 +2848,15 @@  static const struct usb_device_id uvc_ids[] = {
 	  .bInterfaceProtocol	= 0,
 	  .driver_info		= UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
 					| UVC_QUIRK_BUILTIN_ISIGHT) },
+	/* Apple FaceTime HD Camera (Built-In) */
+	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
+				| USB_DEVICE_ID_MATCH_INT_INFO,
+	  .idVendor		= 0x05ac,
+	  .idProduct		= 0x8514,
+	  .bInterfaceClass	= USB_CLASS_VIDEO,
+	  .bInterfaceSubClass	= 1,
+	  .bInterfaceProtocol	= 0,
+	  .driver_info		= (kernel_ulong_t)&uvc_quirk_probe_def },
 	/* Apple Built-In iSight via iBridge */
 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
 				| USB_DEVICE_ID_MATCH_INT_INFO,