From patchwork Thu Jan 16 17:45:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Weber X-Patchwork-Id: 3499871 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D57409F32F for ; Thu, 16 Jan 2014 17:46:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 09E0E20154 for ; Thu, 16 Jan 2014 17:46:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC4C420108 for ; Thu, 16 Jan 2014 17:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540AbaAPRp5 (ORCPT ); Thu, 16 Jan 2014 12:45:57 -0500 Received: from mx.hs-offenburg.de ([141.79.128.11]:57212 "EHLO mx.hs-offenburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbaAPRpz (ORCPT ); Thu, 16 Jan 2014 12:45:55 -0500 X-Greylist: delayed 659 seconds by postgrey-1.27 at vger.kernel.org; Thu, 16 Jan 2014 12:45:55 EST Received: from [141.79.65.136] (asa2.rz.hs-offenburg.de [141.79.10.2]) by mx.hs-offenburg.de (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id s0GHjuiN015667 for ; Thu, 16 Jan 2014 18:45:57 +0100 Message-ID: <52D81AD4.3050504@hs-offenburg.de> Date: Thu, 16 Jan 2014 18:45:56 +0100 From: Andreas Weber User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: linux-media@vger.kernel.org Subject: 2 bugs (errno = EINTR) in v4l2grab.c and v4l2gl.c? X-Enigmail-Version: 1.5.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Dear maintainers, I guess these are 2 bugs: contrib/test/v4l2grab.c:132: } while ((r == -1 && (errno = EINTR))); contrib/test/v4l2gl.c:227: } while ((r == -1 && (errno = EINTR))); please consider my attached patch if it's really a bug. Regards, Andy From 63d4fd18cb91852b64c81bf63d0d4100fc53d38d Mon Sep 17 00:00:00 2001 From: Andreas Weber Date: Thu, 16 Jan 2014 18:43:31 +0100 Subject: [PATCH] bugfix for errno assignment in while loop --- contrib/test/v4l2gl.c | 2 +- contrib/test/v4l2grab.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/test/v4l2gl.c b/contrib/test/v4l2gl.c index e921212..4b549c1 100644 --- a/contrib/test/v4l2gl.c +++ b/contrib/test/v4l2gl.c @@ -224,7 +224,7 @@ static int capture(char *dev_name, int x_res, int y_res, int n_frames, tv.tv_usec = 0; r = select(fd + 1, &fds, NULL, NULL, &tv); - } while ((r == -1 && (errno = EINTR))); + } while ((r == -1 && (errno == EINTR))); if (r == -1) { perror("select"); return errno; diff --git a/contrib/test/v4l2grab.c b/contrib/test/v4l2grab.c index a93ad43..14d2a8f 100644 --- a/contrib/test/v4l2grab.c +++ b/contrib/test/v4l2grab.c @@ -129,7 +129,7 @@ static int capture(char *dev_name, int x_res, int y_res, int n_frames, tv.tv_usec = 0; r = select(fd + 1, &fds, NULL, NULL, &tv); - } while ((r == -1 && (errno = EINTR))); + } while ((r == -1 && (errno == EINTR))); if (r == -1) { perror("select"); return errno; -- 1.7.10.4