From patchwork Wed May 11 18:47:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David X-Patchwork-Id: 9073861 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 202309F30C for ; Wed, 11 May 2016 18:47:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 62AEE2017D for ; Wed, 11 May 2016 18:47:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A1DE2014A for ; Wed, 11 May 2016 18:47:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbcEKSrZ (ORCPT ); Wed, 11 May 2016 14:47:25 -0400 Received: from mx1.unsolicited.net ([173.255.193.191]:39861 "EHLO mx1.unsolicited.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbcEKSrY (ORCPT ); Wed, 11 May 2016 14:47:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=unsolicited.net; s=one; h=Content-Type:MIME-Version:Date:Message-ID:Subject :From:Cc:To:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4BtJG4H4ue1gqy5nkzzqDoYk7pBBYKj2oW8J7Ami0MY=; b=U8v5ObQrC302mMgDlwqvxsh2Qm tZtFhUkARlgz6ecGByKoKgX0P6/NX9z7beZB94NDyEoeyCNGSK1pWH8q9zEhGaaeTHyfaaoa+ibHZ pvu91kaMWClIMO96mdXpOPHWGEmBQmVsYhvbet/Ka95hECnI2UXCCbirUnhBmlGOfkyRazC3IyqOR n7ipdYBv+Ay5bGXoozXxaC3gLug5VR597Ax8A27MItrP6bP6sXXJtyQQuXAeUOKJyVj0Jonxg0Jxa tNWmYSsoRwhTTjpnEDlfmOSRATSl13PsRbBapgvs0zL73LOpKcr2tVbjvtnzh1rqNbxHZofuH+Oi0 fRKYmSog==; To: Linux Media Mailing List Cc: Linux Kernel Mailing List , gregkh@linuxfoundation.org From: David R Subject: Patch: V4L stable versions 4.5.3 and 4.5.4 Message-ID: <57337E39.40105@unsolicited.net> Date: Wed, 11 May 2016 19:47:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_ADSP_ALL, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Please consider applying the attached patch (or something like it) to V4L2, and whatever is appropriate to the mainstream kernel. Without this my media server crashes and burns at boot. See https://lkml.org/lkml/2016/5/7/88 for more details Thanks David --- drivers/media/v4l2-core/videobuf2-core.c.old 2016-05-11 18:44:50.917083559 +0100 +++ drivers/media/v4l2-core/videobuf2-core.c 2016-05-11 18:45:10.136184837 +0100 @@ -1665,7 +1665,7 @@ static int __vb2_get_done_vb(struct vb2_ * Only remove the buffer from done_list if v4l2_buffer can handle all * the planes. */ - ret = call_bufop(q, verify_planes_array, *vb, pb); + ret = pb ? call_bufop(q, verify_planes_array, *vb, pb) : 0; if (!ret) list_del(&(*vb)->done_entry); spin_unlock_irqrestore(&q->done_lock, flags);