From patchwork Thu Jul 7 13:02:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hans Verkuil (hansverk)" X-Patchwork-Id: 9218957 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A49C960574 for ; Thu, 7 Jul 2016 13:02:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9643B200F5 for ; Thu, 7 Jul 2016 13:02:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B1CD20453; Thu, 7 Jul 2016 13:02:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, USER_IN_DEF_DKIM_WL autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 626DE200F5 for ; Thu, 7 Jul 2016 13:02:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650AbcGGNCq (ORCPT ); Thu, 7 Jul 2016 09:02:46 -0400 Received: from aer-iport-2.cisco.com ([173.38.203.52]:22609 "EHLO aer-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbcGGNCk (ORCPT ); Thu, 7 Jul 2016 09:02:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1111; q=dns/txt; s=iport; t=1467896560; x=1469106160; h=from:subject:to:message-id:date:mime-version: content-transfer-encoding; bh=pv4ACOnLK2by/Rkj7lPJVOdC9baMcRcTYRJuqyjvDYs=; b=LDIoSBc55d5yz/ed+LS75vYezw/dR31gKinbrB9qKN8XB6Gfdh9KZOR/ srL308edczOtfUHPoAatzh9+T0ivY3bx4ZIJkYpP2YEMl/acIupDGCcc+ JZAS20UZ7MhVKCj+dDKcCb/EkK+zmvV/9unJqK+8P6oFRA2uka9RYUGmd M=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0DNAQAFUn5X/xbLJq1bhRC3C4IPgXuHe?= =?us-ascii?q?hQBAQEBAQEBZSeEdgRRNgIFFgsCCwMCAQIBSw0GAgKILJ4Nj2KPQAEBCAIBJIE?= =?us-ascii?q?BhSaMDoJaAQSZE45HiUuFXQKQCh42ggkcgU46Moh8AQEB?= X-IronPort-AV: E=Sophos;i="5.28,324,1464652800"; d="scan'208";a="635578751" Received: from aer-iport-nat.cisco.com (HELO aer-core-1.cisco.com) ([173.38.203.22]) by aer-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jul 2016 13:02:07 +0000 Received: from [10.47.79.81] ([10.47.79.81]) (authenticated bits=0) by aer-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id u67D26I1026004 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Thu, 7 Jul 2016 13:02:06 GMT From: Hans Verkuil Subject: [PATCH] cec-funcs.h: add missing 'reply' for short audio descriptor To: linux-media Message-ID: <577E52CE.2060702@cisco.com> Date: Thu, 7 Jul 2016 15:02:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 X-Authenticated-User: hansverk Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The cec_msg_request_short_audio_descriptor function was missing the reply argument. That's needed if you want the framework to wait for the reply message. Signed-off-by: Hans Verkuil --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/cec-funcs.h b/include/linux/cec-funcs.h index 19486009..763d0fe 100644 --- a/include/linux/cec-funcs.h +++ b/include/linux/cec-funcs.h @@ -1495,6 +1495,7 @@ static inline void cec_ops_report_short_audio_descriptor(const struct cec_msg *m static inline void cec_msg_request_short_audio_descriptor(struct cec_msg *msg, __u8 num_descriptors, + bool reply, const __u8 *audio_format_id, const __u8 *audio_format_code) { @@ -1504,6 +1505,7 @@ static inline void cec_msg_request_short_audio_descriptor(struct cec_msg *msg, num_descriptors = 4; msg->len = 2 + num_descriptors; msg->msg[1] = CEC_MSG_REQUEST_SHORT_AUDIO_DESCRIPTOR; + msg->reply = reply ? CEC_MSG_REPORT_SHORT_AUDIO_DESCRIPTOR : 0; for (i = 0; i < num_descriptors; i++) msg->msg[2 + i] = (audio_format_id[i] << 6) | (audio_format_code[i] & 0x3f);