From patchwork Tue Jun 20 12:42:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanimir Varbanov X-Patchwork-Id: 9799393 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 56D85600F6 for ; Tue, 20 Jun 2017 12:42:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45D1728488 for ; Tue, 20 Jun 2017 12:42:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2FB512848F; Tue, 20 Jun 2017 12:42:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B2EA28488 for ; Tue, 20 Jun 2017 12:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbdFTMmd (ORCPT ); Tue, 20 Jun 2017 08:42:33 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36968 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbdFTMmc (ORCPT ); Tue, 20 Jun 2017 08:42:32 -0400 Received: by mail-wm0-f51.google.com with SMTP id d73so19023808wma.0 for ; Tue, 20 Jun 2017 05:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=vhGLuWeFiUi51jqkka+zOqicYTzYefBYmDAmjDrLBpA=; b=kHSnQrtMD12XzCcc46k4OcOLxpYGDxu/ENifmC0B535K9JYBj/14y/JKznxnJFk0gk yDaX7cg2SCvudkLaaqBRYormuX4TexZgDeh+pniqElI93cmy0xmqBl1jEqVanSWcj07/ pial4EDsJOmxcWfKI/1rtHtDAcLBAP5kRh++I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=vhGLuWeFiUi51jqkka+zOqicYTzYefBYmDAmjDrLBpA=; b=rZu+e0Yh8DDDNrPdp9kd2Ite3eamOCwyCopl4SIfVGfrfVPgoa4WrROftE9wzpDgJS BQOtg8L0tGZBVZoikdFYhtnpDFg6JLydm4USrqWCZZVhJGwwG/VP5v8RsYzf/S14fqzi rDLWdsXimNVqnlbJ7y1IVNlx64MVLdU9qg1ipSq8fEu89Eii/I28EbsGmfsZLrmkWMNi Ekush1+rU8weVxBM0/RLPQIhHJ28dpPYGb+o6eBmCnd55jdP5vKkRM4lkunhu92SKevL fD21UqCkWnolwK66eH5w9oxGE5B4J6iFjeF43y6CYkrviNGBw85b0mRFugMkTL8ckPll tJNQ== X-Gm-Message-State: AKS2vOzXQ7XisqJDTKLrNEOXEBZK0iQ5bLqbba5PVcMFATd4OOfaIWra f+95vryrUOAdJRaN X-Received: by 10.80.215.158 with SMTP id w30mr20550358edi.161.1497962550784; Tue, 20 Jun 2017 05:42:30 -0700 (PDT) Received: from [192.168.27.209] ([37.157.136.206]) by smtp.googlemail.com with ESMTPSA id f38sm8482947edd.10.2017.06.20.05.42.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jun 2017 05:42:30 -0700 (PDT) Subject: Re: [GIT PULL FOR v4.13] Add qcom venus driver To: Mauro Carvalho Chehab , Hans Verkuil References: <9a84a004-ebdc-fba7-2cee-b91857788599@xs4all.nl> <20170620085951.11e5c8dd@vento.lan> Cc: Linux Media Mailing List , Stanimir Varbanov From: Stanimir Varbanov Message-ID: <5ecc833a-e59b-475b-d001-39367b52f46e@linaro.org> Date: Tue, 20 Jun 2017 15:42:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170620085951.11e5c8dd@vento.lan> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Mauro, On 06/20/2017 02:59 PM, Mauro Carvalho Chehab wrote: > Em Fri, 16 Jun 2017 10:19:46 +0200 > Hans Verkuil escreveu: > >> Hi Mauro, >> >> Second attempt to add the venus driver. >> >> Regards, >> >> Hans >> >> The following changes since commit acec3630155763c170c7ae6508cf973355464508: >> >> [media] s3c-camif: fix arguments position in a function call (2017-06-13 14:21:24 -0300) >> >> are available in the git repository at: >> >> git://linuxtv.org/hverkuil/media_tree.git venus >> >> for you to fetch changes up to 3bf1c3aacb172db8fcbd25c62b042fc265c5a494: >> >> media: venus: enable building with COMPILE_TEST (2017-06-16 09:59:36 +0200) >> >> ---------------------------------------------------------------- >> Stanimir Varbanov (19): >> media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management >> doc: DT: venus: binding document for Qualcomm video driver >> MAINTAINERS: Add Qualcomm Venus video accelerator driver >> media: venus: adding core part and helper functions >> media: venus: vdec: add video decoder files >> media: venus: venc: add video encoder files >> media: venus: hfi: add Host Firmware Interface (HFI) >> media: venus: hfi: add Venus HFI files >> media: venus: enable building of Venus video driver >> media: venus: hfi: fix mutex unlock >> media: venus: hfi_cmds: fix variable dereferenced before check >> media: venus: helpers: fix variable dereferenced before check >> media: venus: hfi_venus: fix variable dereferenced before check >> media: venus: hfi_msgs: fix set but not used variables >> media: venus: vdec: fix compile error in vdec_close >> media: venus: venc: fix compile error in venc_close >> media: venus: vdec: add support for min buffers for capture >> media: venus: update firmware path with linux-firmware place > > >> media: venus: enable building with COMPILE_TEST > > It is too early for this patch. I merged from 4.12-rc6, and it > still complains about those missing symbols: > > WARNING: "qcom_scm_is_available" [drivers/media/platform/qcom/venus/venus-core.ko] undefined! > WARNING: "qcom_scm_pas_shutdown" [drivers/media/platform/qcom/venus/venus-core.ko] undefined! > WARNING: "qcom_scm_set_remote_state" [drivers/media/platform/qcom/venus/venus-core.ko] undefined! > > Probably, some patch is needed somewhere to replace those functions > by stubs if not the right arch, in order to make it build with > COMPILE_TEST. > > For now, I'm excluding this patch on today's pull. It seems that the patch for the qcom_scm will be delayed, so I have to fix this in the Venus Kconfig, which doesn't seem too bad because we want to allow compile test for the venus driver itself not for its dependencies. So if you are fine with the above change I can cook a patch? diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index f9bbba5c5dd6..b7381a4722e2 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -468,7 +468,8 @@ config VIDEO_QCOM_VENUS tristate "Qualcomm Venus V4L2 encoder/decoder driver" depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA depends on (ARCH_QCOM && IOMMU_DMA) || COMPILE_TEST - select QCOM_MDT_LOADER + select QCOM_MDT_LOADER if (ARM || ARM64) + select QCOM_SCM if (ARM || ARM64) select VIDEOBUF2_DMA_SG select V4L2_MEM2MEM_DEV ---help---