| Message ID | 5f850d5d45a27c50dabf3da08689cbedf986841b.1410288748.git.m.chehab@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thanks, Mauro, On Tue, 9 Sep 2014, Mauro Carvalho Chehab wrote: > This driver depends on a legacy OMAP DMA API. So, it won't > compile-test on other archs. > > While we might add stubs to the functions, this is not a > good idea, as the hole API should be replaced. > > So, for now, let's just remove COMPILE_TEST and wait for > some time for people to fix. If not fixed, then we'll end > by removing this driver as a hole. > > Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Regards Guennadi > > diff --git a/drivers/media/platform/soc_camera/Kconfig b/drivers/media/platform/soc_camera/Kconfig > index 6af6c6dccda8..f2776cd415ca 100644 > --- a/drivers/media/platform/soc_camera/Kconfig > +++ b/drivers/media/platform/soc_camera/Kconfig > @@ -63,7 +63,7 @@ config VIDEO_SH_MOBILE_CEU > config VIDEO_OMAP1 > tristate "OMAP1 Camera Interface driver" > depends on VIDEO_DEV && SOC_CAMERA > - depends on ARCH_OMAP1 || COMPILE_TEST > + depends on ARCH_OMAP1 > depends on HAS_DMA > select VIDEOBUF_DMA_CONTIG > select VIDEOBUF_DMA_SG > -- > 1.9.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tuesday, September 09, 2014 03:54:04 PM Mauro Carvalho Chehab wrote: > This driver depends on a legacy OMAP DMA API. So, it won't > compile-test on other archs. > > While we might add stubs to the functions, this is not a > good idea, as the hole API should be replaced. This is also not a good idea becaouse it would break the driver for OMAP1 once somebody enables COMPILE_TEST option while also having ARCH_OMAP1 enabled (which is perfectly fine and shouldn't cause the driver breakage). In general COMPILE_TEST option is completely independent from the arch specific ones and it should not change behaviour of the existing code. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > So, for now, let's just remove COMPILE_TEST and wait for > some time for people to fix. If not fixed, then we'll end > by removing this driver as a hole. > > Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> > > diff --git a/drivers/media/platform/soc_camera/Kconfig b/drivers/media/platform/soc_camera/Kconfig > index 6af6c6dccda8..f2776cd415ca 100644 > --- a/drivers/media/platform/soc_camera/Kconfig > +++ b/drivers/media/platform/soc_camera/Kconfig > @@ -63,7 +63,7 @@ config VIDEO_SH_MOBILE_CEU > config VIDEO_OMAP1 > tristate "OMAP1 Camera Interface driver" > depends on VIDEO_DEV && SOC_CAMERA > - depends on ARCH_OMAP1 || COMPILE_TEST > + depends on ARCH_OMAP1 > depends on HAS_DMA > select VIDEOBUF_DMA_CONTIG > select VIDEOBUF_DMA_SG -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday, September 10, 2014 10:04:12 AM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, September 09, 2014 03:54:04 PM Mauro Carvalho Chehab wrote: > > This driver depends on a legacy OMAP DMA API. So, it won't > > compile-test on other archs. > > > > While we might add stubs to the functions, this is not a > > good idea, as the hole API should be replaced. > > This is also not a good idea becaouse it would break the driver > for OMAP1 once somebody enables COMPILE_TEST option while also > having ARCH_OMAP1 enabled (which is perfectly fine and shouldn't > cause the driver breakage). In general COMPILE_TEST option is > completely independent from the arch specific ones and it should > not change behaviour of the existing code. Small clarification: I was of course referring to the original patch for the issue: https://lkml.org/lkml/2014/9/9/498 stubs can be added properly with using #if defined(CONFIG_COMPILE_TEST) && !defined(CONFIG_ARCH_OMAP1) similarly like it is handled for ARCH_QCOM in drivers/gpu/drm/msm/msm_drv.h Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/soc_camera/Kconfig b/drivers/media/platform/soc_camera/Kconfig index 6af6c6dccda8..f2776cd415ca 100644 --- a/drivers/media/platform/soc_camera/Kconfig +++ b/drivers/media/platform/soc_camera/Kconfig @@ -63,7 +63,7 @@ config VIDEO_SH_MOBILE_CEU config VIDEO_OMAP1 tristate "OMAP1 Camera Interface driver" depends on VIDEO_DEV && SOC_CAMERA - depends on ARCH_OMAP1 || COMPILE_TEST + depends on ARCH_OMAP1 depends on HAS_DMA select VIDEOBUF_DMA_CONTIG select VIDEOBUF_DMA_SG
This driver depends on a legacy OMAP DMA API. So, it won't compile-test on other archs. While we might add stubs to the functions, this is not a good idea, as the hole API should be replaced. So, for now, let's just remove COMPILE_TEST and wait for some time for people to fix. If not fixed, then we'll end by removing this driver as a hole. Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>