| Message ID | 613dc41c-7174-7c32-7c28-c05ff1e8348c@xs4all.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL,FOR,v5.11] rkisp1 fixes/changes | expand |
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/613dc41c-7174-7c32-7c28-c05ff1e8348c@xs4all.nl/
Build log: https://builder.linuxtv.org/job/patchwork/74814/
Build time: 00:14:06
Link: https://lore.kernel.org/linux-media/613dc41c-7174-7c32-7c28-c05ff1e8348c@xs4all.nl
gpg: Signature made Fri 30 Oct 2020 09:12:01 AM UTC
gpg: using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]
gpg: Note: This key has expired!
Primary key fingerprint: 052C DE7B C215 053B 689F 1BCA BD2D 6148 6614 3B4C
Subkey fingerprint: AAA7 FFBA 4D2D 77EF 4CAE A142 1326 E0CD 23AB DCE5
Summary: got 5/17 patches with issues, being 0 at build time, plus one error when buinding PDF document
Error/warnings:
patches/0009-media-staging-rkisp1-capture-set-default-quantizatio.patch:
checkpatch.pl:
$ cat patches/0009-media-staging-rkisp1-capture-set-default-quantizatio.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:11: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
patches/0012-media-staging-dt-bindings-rkisp1-drop-i2c-unit-addre.patch:
checkpatch.pl:
$ cat patches/0012-media-staging-dt-bindings-rkisp1-drop-i2c-unit-addre.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:9: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
-:10: WARNING: 'unecessary' may be misspelled - perhaps 'unnecessary'?
patches/0014-media-staging-dt-bindings-rkisp1-drop-parent-unit-ad.patch:
checkpatch.pl:
$ cat patches/0014-media-staging-dt-bindings-rkisp1-drop-parent-unit-ad.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:9: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
patches/0015-media-staging-rkisp1-remove-unecessary-clocks.patch:
checkpatch.pl:
$ cat patches/0015-media-staging-rkisp1-remove-unecessary-clocks.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:4: WARNING: 'unecessary' may be misspelled - perhaps 'unnecessary'?
patches/0016-dt-bindings-media-rkisp1-move-rockchip-isp1-bindings.patch:
checkpatch.pl:
$ cat patches/0016-dt-bindings-media-rkisp1-move-rockchip-isp1-bindings.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:9: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
-:18: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
Error #512 when building PDF docs
Em Fri, 30 Oct 2020 10:17:06 +0100 Hans Verkuil <hverkuil@xs4all.nl> escreveu: > After this series there are only a handful patches remaining before this > driver can be moved out of staging. > > Dafna, I marked the patches that need a bit more work as 'Changes Requested'. > It looks like it isn't much work to make a new version of those few patches. > It would be nice to get this done early in the v5.11 cycle. > > Regards, > > Hans > > The following changes since commit dfe3d19bd092cefb184c6e65b881602c793edd33: > > Merge tag 'v5.10-rc1' into patchwork (2020-10-29 09:03:21 +0100) > > are available in the Git repository at: > > git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.11b > > for you to fetch changes up to 698e29d26ee79103310dd09a2b7ba09d9febd41a: > > media: MAINTAINERS: rkisp1: add path to dt-bindings (2020-10-30 10:02:18 +0100) > > ---------------------------------------------------------------- > Tag branch > > ---------------------------------------------------------------- > Dafna Hirschfeld (9): > media: staging: rkisp1: remove TODO item to document quantization handling > media: staging: rkisp1: validate links before powering and streaming > media: staging: rkisp1: params: in stop_streaming, use list_splice_init to move the buffers > media: staging: rkisp1: initialize buffer lists only on probe > media: staging: rkisp1: remove the 'is_streaming' field from stats and params > media: staging: rkisp1: params: remove unnecessary "!!" > media: staging: rkisp1: params: remove unnecessary parentheses > media: staging: rkisp1: uapi: add "WITH Linux-syscall-note" > media: staging: rkisp1: capture: set default quantization on 'set_fmt' > > Helen Koike (8): > media: staging: rkisp1: cap: refactor enable/disable stream to allow multistreaming > media: staging: dt-bindings: rkisp1: add missing required nodes > media: staging: dt-bindings: rkisp1: drop i2c unit address > media: staging: dt-bindings: rkisp1: re-order properties > media: staging: dt-bindings: rkisp1: drop parent unit address > media: staging: rkisp1: remove unecessary clocks Applied all the above... > dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging > media: MAINTAINERS: rkisp1: add path to dt-bindings ... except by those two, as they should be placed together with a patch moving the driver out of staging. Regards, Mauro > > .../devicetree/bindings/media/rockchip-isp1.yaml | 81 +++++++---- > MAINTAINERS | 2 + > drivers/staging/media/rkisp1/TODO | 4 - > drivers/staging/media/rkisp1/rkisp1-capture.c | 241 ++++++++++++++++--------------- > drivers/staging/media/rkisp1/rkisp1-common.h | 12 +- > drivers/staging/media/rkisp1/rkisp1-dev.c | 8 +- > drivers/staging/media/rkisp1/rkisp1-params.c | 87 ++++------- > drivers/staging/media/rkisp1/rkisp1-stats.c | 21 --- > drivers/staging/media/rkisp1/uapi/rkisp1-config.h | 2 +- > 9 files changed, 216 insertions(+), 242 deletions(-) > rename {drivers/staging/media/rkisp1/Documentation => Documentation}/devicetree/bindings/media/rockchip-isp1.yaml (81%) Thanks, Mauro
After this series there are only a handful patches remaining before this driver can be moved out of staging. Dafna, I marked the patches that need a bit more work as 'Changes Requested'. It looks like it isn't much work to make a new version of those few patches. It would be nice to get this done early in the v5.11 cycle. Regards, Hans The following changes since commit dfe3d19bd092cefb184c6e65b881602c793edd33: Merge tag 'v5.10-rc1' into patchwork (2020-10-29 09:03:21 +0100) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.11b for you to fetch changes up to 698e29d26ee79103310dd09a2b7ba09d9febd41a: media: MAINTAINERS: rkisp1: add path to dt-bindings (2020-10-30 10:02:18 +0100) ---------------------------------------------------------------- Tag branch ---------------------------------------------------------------- Dafna Hirschfeld (9): media: staging: rkisp1: remove TODO item to document quantization handling media: staging: rkisp1: validate links before powering and streaming media: staging: rkisp1: params: in stop_streaming, use list_splice_init to move the buffers media: staging: rkisp1: initialize buffer lists only on probe media: staging: rkisp1: remove the 'is_streaming' field from stats and params media: staging: rkisp1: params: remove unnecessary "!!" media: staging: rkisp1: params: remove unnecessary parentheses media: staging: rkisp1: uapi: add "WITH Linux-syscall-note" media: staging: rkisp1: capture: set default quantization on 'set_fmt' Helen Koike (8): media: staging: rkisp1: cap: refactor enable/disable stream to allow multistreaming media: staging: dt-bindings: rkisp1: add missing required nodes media: staging: dt-bindings: rkisp1: drop i2c unit address media: staging: dt-bindings: rkisp1: re-order properties media: staging: dt-bindings: rkisp1: drop parent unit address media: staging: rkisp1: remove unecessary clocks dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging media: MAINTAINERS: rkisp1: add path to dt-bindings .../devicetree/bindings/media/rockchip-isp1.yaml | 81 +++++++---- MAINTAINERS | 2 + drivers/staging/media/rkisp1/TODO | 4 - drivers/staging/media/rkisp1/rkisp1-capture.c | 241 ++++++++++++++++--------------- drivers/staging/media/rkisp1/rkisp1-common.h | 12 +- drivers/staging/media/rkisp1/rkisp1-dev.c | 8 +- drivers/staging/media/rkisp1/rkisp1-params.c | 87 ++++------- drivers/staging/media/rkisp1/rkisp1-stats.c | 21 --- drivers/staging/media/rkisp1/uapi/rkisp1-config.h | 2 +- 9 files changed, 216 insertions(+), 242 deletions(-) rename {drivers/staging/media/rkisp1/Documentation => Documentation}/devicetree/bindings/media/rockchip-isp1.yaml (81%)