diff mbox series

[23/38] media: saa7134: avoid a shift overflow

Message ID	6ee0a9ec8855f0388fee8cd183abeb60e28b293f.1599062230.git.mchehab+huawei@kernel.org (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=Cf27=CL=vger.kernel.org=linux-media-owner@kernel.org> From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 23/38] media: saa7134: avoid a shift overflow Date: Wed, 2 Sep 2020 18:10:26 +0200 Message-Id: <6ee0a9ec8855f0388fee8cd183abeb60e28b293f.1599062230.git.mchehab+huawei@kernel.org> In-Reply-To: <cover.1599062230.git.mchehab+huawei@kernel.org> References: <cover.1599062230.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk
Series	media sparse/smatch warn fixes \| expand [00/38] media sparse/smatch warn fixes [01/38] media: tda10086: cleanup symbol_rate setting logic [02/38] media: v4l2-ioctl: avoid memory leaks on some time32 compat functions [03/38] media: qt1010: fix usage of unititialized value [04/38] media: av7110_v4l: avoid a typecast [05/38] media: wl128x: get rid of a potential spectre issue [06/38] media: venus: place extern venus_fw_debug on a header file [07/38] media: tda10021: avoid casts when using symbol_rate [08/38] media: serial_ir: use the right type for a dma address [09/38] media: vivid: move the detection part out of vivid_create_instance [10/38] media: vivid: place the logic which disables ioctl on a separate function [11/38] media: vivid: move set_capabilities logic to a separate function [12/38] media: vivid: place dt timings init code on a separate function [13/38] media: vivid: move the create queues to a separate function [14/38] media: vivid: move the devnode creation logic to a separate function [15/38] media: vivid: fix error path [16/38] media: videobuf-dma-sg: number of pages should be unsigned long [17/38] media: cx25821-alsa: number of pages should be unsigned long [18/38] media: cx23885-alsa: number of pages should be unsigned long [19/38] media: cx88-alsa: number of pages should be unsigned long [20/38] media: saa7134-alsa.c: number of pages should be unsigned long [21/38] media: dvb-ttusb-budget: don't use stack for USB transfers [22/38] media: dvb-ttusb-budget: cleanup printk logic [23/38] media: saa7134: avoid a shift overflow [24/38] media: atomisp: fix casts at atomisp_compat_ioctl32.c [25/38] media: atomisp: get rid of some unused code [26/38] media: atomisp: cleanup ifdefs from ia_css_debug.c [27/38] media: atomisp: get rid of version-dependent globals [28/38] media: atomisp: get rid of isys_dma.h and isys_dma_local.h [29/38] media: atomisp: get rid of ibuf_ctrl abstraction [30/38] media: atomisp: don't check for ISP version for includes [31/38] media: atomisp: unify INPUT error return type [32/38] media: atomisp: de-duplicate names at *_input_system_global.h [33/38] media: atomisp: reorder functions at pixelgen_private.h [34/38] media: atomisp: remove compile-time tests from input_system_global.h [35/38] media: atomisp: fix some bad indents [36/38] media: atomisp: csi_rx.c: add a missing includes [37/38] media: atomisp: atomisp_gmin_platform: check before use [38/38] media: atomisp: cleanup isys_irq headers

Commit Message

Mauro Carvalho Chehab Sept. 2, 2020, 4:10 p.m. UTC

As reported by smatch:
	drivers/media/pci/saa7134//saa7134-tvaudio.c:686 saa_dsp_writel() warn: should 'reg << 2' be a 64 bit type?

On a 64-bits Kernel, the shift might be bigger than 32 bits.

In real, this should never happen, but let's shut up the warning.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
 drivers/media/pci/saa7134/saa7134-tvaudio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/media/pci/saa7134/saa7134-tvaudio.c b/drivers/media/pci/saa7134/saa7134-tvaudio.c
index 79e1afb71075..5cc4ef21f9d3 100644
--- a/drivers/media/pci/saa7134/saa7134-tvaudio.c
+++ b/drivers/media/pci/saa7134/saa7134-tvaudio.c
@@ -683,7 +683,8 @@  int saa_dsp_writel(struct saa7134_dev *dev, int reg, u32 value)
 {
 	int err;
 
-	audio_dbg(2, "dsp write reg 0x%x = 0x%06x\n", reg << 2, value);
+	audio_dbg(2, "dsp write reg 0x%x = 0x%06x\n",
+		  (reg << 2) & 0xffffffff, value);
 	err = saa_dsp_wait_bit(dev,SAA7135_DSP_RWSTATE_WRR);
 	if (err < 0)
 		return err;