diff mbox

[09051_47] Siano: smsdvb - add DVB v3 events

Message ID 713142.1655.qm@web110815.mail.gq1.yahoo.com (mailing list archive)
State Accepted
Headers show

Commit Message

Uri Shkolnik May 19, 2009, 3:28 p.m. UTC
# HG changeset patch
# User Uri Shkolnik <uris@siano-ms.com>
# Date 1242747164 -10800
# Node ID 971d4cc0d4009650bd4752c6a9fc09755ef77baf
# Parent  98895daafb42f8b0757fd608b29c53c80327520e
[09051_47] Siano: smsdvb - add DVB v3 events

From: Uri Shkolnik <uris@siano-ms.com>

Add various DVB-API v3 events, those events will trig
target (card) events.

Priority: normal

Signed-off-by: Uri Shkolnik <uris@siano-ms.com>




      
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Michael Ira Krufky May 19, 2009, 4:18 p.m. UTC | #1
On Tue, May 19, 2009 at 11:28 AM, Uri Shkolnik <urishk@yahoo.com> wrote:
>
> # HG changeset patch
> # User Uri Shkolnik <uris@siano-ms.com>
> # Date 1242747164 -10800
> # Node ID 971d4cc0d4009650bd4752c6a9fc09755ef77baf
> # Parent  98895daafb42f8b0757fd608b29c53c80327520e
> [09051_47] Siano: smsdvb - add DVB v3 events
>
> From: Uri Shkolnik <uris@siano-ms.com>
>
> Add various DVB-API v3 events, those events will trig
> target (card) events.
>
> Priority: normal
>
> Signed-off-by: Uri Shkolnik <uris@siano-ms.com>
>
> diff -r 98895daafb42 -r 971d4cc0d400 linux/drivers/media/dvb/siano/smsdvb.c
> --- a/linux/drivers/media/dvb/siano/smsdvb.c    Tue May 19 18:27:38 2009 +0300
> +++ b/linux/drivers/media/dvb/siano/smsdvb.c    Tue May 19 18:32:44 2009 +0300
> @@ -66,6 +66,54 @@ MODULE_PARM_DESC(debug, "set debug level
>  /* Events that may come from DVB v3 adapter */
>  static void sms_board_dvb3_event(struct smsdvb_client_t *client,
>                enum SMS_DVB3_EVENTS event) {
> +
> +       struct smscore_device_t *coredev = client->coredev;
> +       switch (event) {
> +       case DVB3_EVENT_INIT:
> +               sms_debug("DVB3_EVENT_INIT");
> +               sms_board_event(coredev, BOARD_EVENT_BIND);
> +               break;
> +       case DVB3_EVENT_SLEEP:
> +               sms_debug("DVB3_EVENT_SLEEP");
> +               sms_board_event(coredev, BOARD_EVENT_POWER_SUSPEND);
> +               break;
> +       case DVB3_EVENT_HOTPLUG:
> +               sms_debug("DVB3_EVENT_HOTPLUG");
> +               sms_board_event(coredev, BOARD_EVENT_POWER_INIT);
> +               break;
> +       case DVB3_EVENT_FE_LOCK:
> +               if (client->event_fe_state != DVB3_EVENT_FE_LOCK) {
> +                       client->event_fe_state = DVB3_EVENT_FE_LOCK;
> +                       sms_debug("DVB3_EVENT_FE_LOCK");
> +                       sms_board_event(coredev, BOARD_EVENT_FE_LOCK);
> +               }
> +               break;
> +       case DVB3_EVENT_FE_UNLOCK:
> +               if (client->event_fe_state != DVB3_EVENT_FE_UNLOCK) {
> +                       client->event_fe_state = DVB3_EVENT_FE_UNLOCK;
> +                       sms_debug("DVB3_EVENT_FE_UNLOCK");
> +                       sms_board_event(coredev, BOARD_EVENT_FE_UNLOCK);
> +               }
> +               break;
> +       case DVB3_EVENT_UNC_OK:
> +               if (client->event_unc_state != DVB3_EVENT_UNC_OK) {
> +                       client->event_unc_state = DVB3_EVENT_UNC_OK;
> +                       sms_debug("DVB3_EVENT_UNC_OK");
> +                       sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_OK);
> +               }
> +               break;
> +       case DVB3_EVENT_UNC_ERR:
> +               if (client->event_unc_state != DVB3_EVENT_UNC_ERR) {
> +                       client->event_unc_state = DVB3_EVENT_UNC_ERR;
> +                       sms_debug("DVB3_EVENT_UNC_ERR");
> +                       sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_ERRORS);
> +               }
> +               break;
> +
> +       default:
> +               sms_err("Unknown dvb3 api event");
> +               break;
> +       }
>  }
>
>  static int smsdvb_onresponse(void *context, struct smscore_buffer_t *cb)
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



Uri,

I don't understand what prompts you to call these "DVB v3 events" ...
what does this have to do with DVB API v3 at all?  Your idea seems to
be in the right direction, but this "DVBV3" nomenclature is a total
misnomer.

I think something along the lines of SMSBOARD_EVENT_FOO is more appropriate.

Regards,

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -r 98895daafb42 -r 971d4cc0d400 linux/drivers/media/dvb/siano/smsdvb.c
--- a/linux/drivers/media/dvb/siano/smsdvb.c	Tue May 19 18:27:38 2009 +0300
+++ b/linux/drivers/media/dvb/siano/smsdvb.c	Tue May 19 18:32:44 2009 +0300
@@ -66,6 +66,54 @@  MODULE_PARM_DESC(debug, "set debug level
 /* Events that may come from DVB v3 adapter */
 static void sms_board_dvb3_event(struct smsdvb_client_t *client,
 		enum SMS_DVB3_EVENTS event) {
+
+	struct smscore_device_t *coredev = client->coredev;
+	switch (event) {
+	case DVB3_EVENT_INIT:
+		sms_debug("DVB3_EVENT_INIT");
+		sms_board_event(coredev, BOARD_EVENT_BIND);
+		break;
+	case DVB3_EVENT_SLEEP:
+		sms_debug("DVB3_EVENT_SLEEP");
+		sms_board_event(coredev, BOARD_EVENT_POWER_SUSPEND);
+		break;
+	case DVB3_EVENT_HOTPLUG:
+		sms_debug("DVB3_EVENT_HOTPLUG");
+		sms_board_event(coredev, BOARD_EVENT_POWER_INIT);
+		break;
+	case DVB3_EVENT_FE_LOCK:
+		if (client->event_fe_state != DVB3_EVENT_FE_LOCK) {
+			client->event_fe_state = DVB3_EVENT_FE_LOCK;
+			sms_debug("DVB3_EVENT_FE_LOCK");
+			sms_board_event(coredev, BOARD_EVENT_FE_LOCK);
+		}
+		break;
+	case DVB3_EVENT_FE_UNLOCK:
+		if (client->event_fe_state != DVB3_EVENT_FE_UNLOCK) {
+			client->event_fe_state = DVB3_EVENT_FE_UNLOCK;
+			sms_debug("DVB3_EVENT_FE_UNLOCK");
+			sms_board_event(coredev, BOARD_EVENT_FE_UNLOCK);
+		}
+		break;
+	case DVB3_EVENT_UNC_OK:
+		if (client->event_unc_state != DVB3_EVENT_UNC_OK) {
+			client->event_unc_state = DVB3_EVENT_UNC_OK;
+			sms_debug("DVB3_EVENT_UNC_OK");
+			sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_OK);
+		}
+		break;
+	case DVB3_EVENT_UNC_ERR:
+		if (client->event_unc_state != DVB3_EVENT_UNC_ERR) {
+			client->event_unc_state = DVB3_EVENT_UNC_ERR;
+			sms_debug("DVB3_EVENT_UNC_ERR");
+			sms_board_event(coredev, BOARD_EVENT_MULTIPLEX_ERRORS);
+		}
+		break;
+
+	default:
+		sms_err("Unknown dvb3 api event");
+		break;
+	}
 }
 
 static int smsdvb_onresponse(void *context, struct smscore_buffer_t *cb)