| Message ID | 728826957177ee11793b6b28b4e61e94b2d3068c.1441540862.git.mchehab@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/06/2015 02:02 PM, Mauro Carvalho Chehab wrote: > Don't use anymore the type/subtype entity data/macros > inside the Kernel. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index 220864319d21..7320cdc45833 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -185,16 +185,6 @@ struct media_intf_devnode { > u32 minor; > }; > > -static inline u32 media_entity_type(struct media_entity *entity) > -{ > - return entity->type & MEDIA_ENT_TYPE_MASK; > -} > - > -static inline u32 media_entity_subtype(struct media_entity *entity) > -{ > - return entity->type & MEDIA_ENT_SUBTYPE_MASK; > -} > - > static inline u32 media_entity_id(struct media_entity *entity) > { > return entity->graph_obj.id; > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 3d6210095336..f90147cb9b57 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -42,8 +42,6 @@ struct media_device_info { > > #define MEDIA_ENT_ID_FLAG_NEXT (1 << 31) > > -/* Used values for media_entity_desc::type */ > - > /* > * Initial value to be used when a new entity is created > * Drivers should change it to something useful > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro, Thank you for the patch. On Sunday 06 September 2015 09:02:59 Mauro Carvalho Chehab wrote: > Don't use anymore the type/subtype entity data/macros > inside the Kernel. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index 220864319d21..7320cdc45833 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -185,16 +185,6 @@ struct media_intf_devnode { > u32 minor; > }; > > -static inline u32 media_entity_type(struct media_entity *entity) > -{ > - return entity->type & MEDIA_ENT_TYPE_MASK; > -} > - > -static inline u32 media_entity_subtype(struct media_entity *entity) > -{ > - return entity->type & MEDIA_ENT_SUBTYPE_MASK; > -} > - > static inline u32 media_entity_id(struct media_entity *entity) > { > return entity->graph_obj.id; > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 3d6210095336..f90147cb9b57 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -42,8 +42,6 @@ struct media_device_info { > > #define MEDIA_ENT_ID_FLAG_NEXT (1 << 31) > > -/* Used values for media_entity_desc::type */ > - > /* > * Initial value to be used when a new entity is created > * Drivers should change it to something useful
diff --git a/include/media/media-entity.h b/include/media/media-entity.h index 220864319d21..7320cdc45833 100644 --- a/include/media/media-entity.h +++ b/include/media/media-entity.h @@ -185,16 +185,6 @@ struct media_intf_devnode { u32 minor; }; -static inline u32 media_entity_type(struct media_entity *entity) -{ - return entity->type & MEDIA_ENT_TYPE_MASK; -} - -static inline u32 media_entity_subtype(struct media_entity *entity) -{ - return entity->type & MEDIA_ENT_SUBTYPE_MASK; -} - static inline u32 media_entity_id(struct media_entity *entity) { return entity->graph_obj.id; diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index 3d6210095336..f90147cb9b57 100644 --- a/include/uapi/linux/media.h +++ b/include/uapi/linux/media.h @@ -42,8 +42,6 @@ struct media_device_info { #define MEDIA_ENT_ID_FLAG_NEXT (1 << 31) -/* Used values for media_entity_desc::type */ - /* * Initial value to be used when a new entity is created * Drivers should change it to something useful
Don't use anymore the type/subtype entity data/macros inside the Kernel. Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>