mbox series

[GIT,PULL,FOR,v5.9] Finalize stateful encoder support

Message ID 741fd4cb-1c56-9546-36da-1993474caf49@xs4all.nl (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL,FOR,v5.9] Finalize stateful encoder support | expand

Pull-request

git://linuxtv.org/hverkuil/media_tree.git tags/br-stateful-enc

Message

Hans Verkuil June 2, 2020, 10:02 a.m. UTC
Hi Mauro,

This PR finalizes the stateful encoder support by adding the stateful encoder
spec. It was delayed quite a bit and the main reason was how framerates should
be handled given the constraints of what existing stateful encoder drivers
implemented.

Michael, can you make a allegro patch that sets the V4L2_FMT_FLAG_ENC_CAP_FRAME_INTERVAL
flag in that driver and have it behave according to this updated spec?

Many thanks to all who contributed, with honorable mention of Tomasz who wrote
the original version of this spec.

Regards,

	Hans

The following changes since commit 938b29db3aa9c293c7c1366b16e55e308f1a1ddd:

  media: Documentation: media: Refer to mbus format documentation from CSI-2 docs (2020-05-25 15:47:02 +0200)

are available in the Git repository at:

  git://linuxtv.org/hverkuil/media_tree.git tags/br-stateful-enc

for you to fetch changes up to f73d82aca17259d7409c3bb675c1def0d71041e0:

  dev-encoder.rst: add reference to V4L2_FMT_FLAG_ENC_CAP_FRAME_INTERVAL (2020-06-02 11:05:51 +0200)

----------------------------------------------------------------
Tag branch

----------------------------------------------------------------
Hans Verkuil (4):
      vidioc-g-parm.rst: update the VIDIOC_G/S_PARM documentation
      dev-decoder.rst: small fixes
      videodev2.h: add V4L2_FMT_FLAG_ENC_CAP_FRAME_INTERVAL flag
      dev-encoder.rst: add reference to V4L2_FMT_FLAG_ENC_CAP_FRAME_INTERVAL

Tomasz Figa (1):
      media: docs-rst: Document memory-to-memory video encoder interface

 Documentation/userspace-api/media/v4l/dev-decoder.rst        |   6 +-
 Documentation/userspace-api/media/v4l/dev-encoder.rst        | 729 ++++++++++++++++++++++++++++++++++++++++
 Documentation/userspace-api/media/v4l/dev-mem2mem.rst        |   1 +
 Documentation/userspace-api/media/v4l/pixfmt-v4l2.rst        |   5 +
 Documentation/userspace-api/media/v4l/v4l2.rst               |   2 +
 Documentation/userspace-api/media/v4l/vidioc-encoder-cmd.rst |  51 +--
 Documentation/userspace-api/media/v4l/vidioc-enum-fmt.rst    |  30 +-
 Documentation/userspace-api/media/v4l/vidioc-g-parm.rst      |  51 +--
 Documentation/userspace-api/media/videodev2.h.rst.exceptions |   1 +
 include/uapi/linux/videodev2.h                               |   1 +
 10 files changed, 830 insertions(+), 47 deletions(-)
 create mode 100644 Documentation/userspace-api/media/v4l/dev-encoder.rst

Comments

Jenkins June 2, 2020, 10:34 a.m. UTC | #1
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/patch/64176/
Build log: https://builder.linuxtv.org/job/patchwork/53633/
Build time: 00:23:59
Link: https://lore.kernel.org/linux-media/741fd4cb-1c56-9546-36da-1993474caf49@xs4all.nl

gpg: Signature made Tue 02 Jun 2020 09:53:49 AM UTC
gpg:                using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg:                 aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]

Summary: 2 patches and/or PDF generation with issues, being 0 at build time

Error/warnings:


Error #256 when running cat patches/0001-media-docs-rst-Document-memory-to-memory-video-encod.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict:
$ cat patches/0001-media-docs-rst-Document-memory-to-memory-video-encod.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
-:37: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
Mauro Carvalho Chehab June 23, 2020, 10:39 a.m. UTC | #2
Em Tue, 2 Jun 2020 12:02:54 +0200
Hans Verkuil <hverkuil-cisco@xs4all.nl> escreveu:

> Hi Mauro,
> 
> This PR finalizes the stateful encoder support by adding the stateful encoder
> spec. It was delayed quite a bit and the main reason was how framerates should
> be handled given the constraints of what existing stateful encoder drivers
> implemented.
> 
> Michael, can you make a allegro patch that sets the V4L2_FMT_FLAG_ENC_CAP_FRAME_INTERVAL
> flag in that driver and have it behave according to this updated spec?
> 
> Many thanks to all who contributed, with honorable mention of Tomasz who wrote
> the original version of this spec.
> 
> Regards,
> 
> 	Hans
> 
> The following changes since commit 938b29db3aa9c293c7c1366b16e55e308f1a1ddd:
> 
>   media: Documentation: media: Refer to mbus format documentation from CSI-2 docs (2020-05-25 15:47:02 +0200)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/hverkuil/media_tree.git tags/br-stateful-enc
> 
> for you to fetch changes up to f73d82aca17259d7409c3bb675c1def0d71041e0:
> 
>   dev-encoder.rst: add reference to V4L2_FMT_FLAG_ENC_CAP_FRAME_INTERVAL (2020-06-02 11:05:51 +0200)
> 
> ----------------------------------------------------------------
> Tag branch
> 
> ----------------------------------------------------------------
> Hans Verkuil (4):
>       vidioc-g-parm.rst: update the VIDIOC_G/S_PARM documentation
>       dev-decoder.rst: small fixes
>       videodev2.h: add V4L2_FMT_FLAG_ENC_CAP_FRAME_INTERVAL flag
>       dev-encoder.rst: add reference to V4L2_FMT_FLAG_ENC_CAP_FRAME_INTERVAL
> 
> Tomasz Figa (1):
>       media: docs-rst: Document memory-to-memory video encoder interface
> 
>  Documentation/userspace-api/media/v4l/dev-decoder.rst        |   6 +-
>  Documentation/userspace-api/media/v4l/dev-encoder.rst        | 729 ++++++++++++++++++++++++++++++++++++++++

There's an issue here:

diff --git a/Documentation/userspace-api/media/v4l/dev-encoder.rst b/Documentation/userspace-api/media/v4l/dev-encoder.rst
new file mode 100644
index 000000000000..aace7b812a9c
--- /dev/null
+++ b/Documentation/userspace-api/media/v4l/dev-encoder.rst
@@ -0,0 +1,728 @@
+.. SPDX-License-Identifier: GPL-2.0

In order to be compatible with the license of the entire uAPI, we need
to use here:

	.. SPDX-License-Identifier: GPL-2.0 OR GFDL-1.1-or-later-no-invariants

E.g. dual GPLv2 and GFDL 1.1 or later.


Thanks,
Mauro