From patchwork Tue May 19 15:34:09 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uri Shkolnik X-Patchwork-Id: 24746 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4JFYPQp004174 for ; Tue, 19 May 2009 15:34:25 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbZESPeJ (ORCPT ); Tue, 19 May 2009 11:34:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752798AbZESPeJ (ORCPT ); Tue, 19 May 2009 11:34:09 -0400 Received: from web110811.mail.gq1.yahoo.com ([67.195.13.234]:23304 "HELO web110811.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752748AbZESPeI (ORCPT ); Tue, 19 May 2009 11:34:08 -0400 Received: (qmail 20040 invoked by uid 60001); 19 May 2009 15:34:09 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1242747249; bh=OwGvTv+GSgCyojqiorEP2ZmxJ2bJP5yh0sxA0ZK7eYM=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:MIME-Version:Content-Type; b=lbl+nsf2GIseB5o415o8EwTzk1gZbhhxyVK1FDRb3kZ8t0Zlq9uYfy6gts9CNiLqxaQJEGlUqG3TwIgUKGrrVyrJt7zVIZweGV3IV/Krvw9hIxUaZW7QnGIc47sL1x3funvubdd53/oERKuK7VARdr5yLFpahFEWM5oMxLxLTr0= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:MIME-Version:Content-Type; b=Sndf7Sa3cwM3ZwfreixWrPKOL6PrNjTq4ltbylehsWNa+5UcMA+9F1os8X74rhQagRr/lMK2SX9L9Lhsp8ZhruCFfEiPEOblecRDp2O83aB8BKtIyyACxtYJ5dWSpx/y7R3phYDZYCxZxRCMLNhxJsO/mIZLxj6FzOUODDhEevI=; Message-ID: <763416.19374.qm@web110811.mail.gq1.yahoo.com> X-YMail-OSG: ogqqd30VM1mc5Du0oT4mL37uWNV9HWnY2decbgWQkzM0Vu448epS1PNjYGFUi__YxcS1nLidGqMpgalQ4wnHBRsqg_IT8qf.NYYjrNOBD.64fWQzZvc2O93o_A87Fll6w3r0qgxaerIZr29P2.FEFn5zXWGVwmsS8.PMqqO.CCfip_pyPfhaPQEpS43Ud5PzzK3i7MvG8e_5dHEyDiIcEQVD5t8feIAbtTkgVdfbhQ5uOcIjJYwDomZn834aM79tPZDcjLv80WhO0A4VY9mVkS.9yJ1njBwn1zdqwl__WurOWbNfSMMfTRoT3fiCWgtYLsBwLKCZNH4TRrnaKqsCRCLbB4cY7UaJaA_Ydcn4.dxoZ1MQl8zETd7F9g-- Received: from [199.203.99.233] by web110811.mail.gq1.yahoo.com via HTTP; Tue, 19 May 2009 08:34:09 PDT X-Mailer: YahooMailClassic/5.3.9 YahooMailWebService/0.7.289.10 Date: Tue, 19 May 2009 08:34:09 -0700 (PDT) From: Uri Shkolnik Subject: [PATCH] [09051_48] Siano: smscore - remove redundant code To: LinuxML MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org # HG changeset patch # User Uri Shkolnik # Date 1242747487 -10800 # Node ID cfb4106f3ceaee9fe8f7e3acc9d4adec1baffe5e # Parent 971d4cc0d4009650bd4752c6a9fc09755ef77baf [09051_48] Siano: smscore - remove redundant code From: Uri Shkolnik remove redundant code, which in the past handled the various components (now independent modules) registrations. Priority: normal Signed-off-by: Uri Shkolnik --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -r 971d4cc0d400 -r cfb4106f3cea linux/drivers/media/dvb/siano/smscoreapi.c --- a/linux/drivers/media/dvb/siano/smscoreapi.c Tue May 19 18:32:44 2009 +0300 +++ b/linux/drivers/media/dvb/siano/smscoreapi.c Tue May 19 18:38:07 2009 +0300 @@ -1645,99 +1645,11 @@ static int __init smscore_module_init(vo INIT_LIST_HEAD(&g_smscore_registry); kmutex_init(&g_smscore_registrylock); -#if 0 /* def SMS_CHAR_CLIENT */ - /* Char interface Register */ - rc = smschar_register(); - if (rc) { - sms_err("Error registering char device client.\n"); - goto smschar_error; - } -#endif - -#if 0 /* def SMS_DVB_CLIENT */ - /* DVB Register */ - rc = smsdvb_register(); - if (rc) { - sms_err("Error registering DVB client.\n"); - goto smsdvb_error; - } -#endif - -#if 0 /* def SMS_NET_CLIENT */ - /* DVB Register */ - rc = smsnet_register(); - if (rc) { - sms_err("Error registering Network client.\n"); - goto smsnet_error; - } -#endif - -#if 0 /* def SMS_USB_BUS_DRV */ - /* USB Register */ - rc = smsusb_register(); - if (rc) { - sms_err("Error registering USB bus driver.\n"); - goto sms_bus_drv_error; - } -#endif - -#if 0 /* def SMS_SPI_BUS_DRV */ - /* USB Register */ - rc = smsspi_register(); - if (rc) { - sms_err("Error registering spi bus driver.\n"); - goto sms_bus_drv_error; - } -#endif - - return rc; -#if 0 -sms_bus_drv_error: -#endif /* 0 */ -#if 0 /* def SMS_NET_CLIENT */ - smsnet_unregister(); -smsnet_error: -#endif -#if 0 /* def SMS_DVB_CLIENT */ - smsdvb_unregister(); -smsdvb_error: -#endif -#if 0 /* def SMS_CHAR_CLIENT */ - smschar_unregister(); -smschar_error: -#endif - sms_debug("rc %d", rc); - return rc; } static void __exit smscore_module_exit(void) { -#if 0 /* def SMS_CHAR_CLIENT */ - /* Char interface UnRegister */ - smschar_unregister(); -#endif - -#if 0 /* def SMS_DVB_CLIENT */ - /* DVB UnRegister */ - smsdvb_unregister(); -#endif - -#if 0 /* def SMS_NET_CLIENT */ - /* NET UnRegister */ - smsnet_unregister(); -#endif - -#if 0 /* def SMS_USB_BUS_DRV */ - /* Unregister USB */ - smsusb_unregister(); -#endif - -#if 0 /* def SMS_SPI_BUS_DRV */ - /* Unregister SPI */ - smsspi_unregister(); -#endif - kmutex_lock(&g_smscore_deviceslock); while (!list_empty(&g_smscore_notifyees)) { struct smscore_device_notifyee_t *notifyee =