From patchwork Mon Jul 25 14:55:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhaktipriya Shridhar X-Patchwork-Id: 9245881 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6C22E607D3 for ; Mon, 25 Jul 2016 14:55:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DE04212D9 for ; Mon, 25 Jul 2016 14:55:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 525A226D08; Mon, 25 Jul 2016 14:55:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A25A212D9 for ; Mon, 25 Jul 2016 14:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753030AbcGYOza (ORCPT ); Mon, 25 Jul 2016 10:55:30 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35996 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752805AbcGYOza (ORCPT ); Mon, 25 Jul 2016 10:55:30 -0400 Received: by mail-pf0-f196.google.com with SMTP id y134so12090884pfg.3; Mon, 25 Jul 2016 07:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :in-reply-to:user-agent; bh=PI3FjEQXtQHOgVGkOwuxpveSGGmx7R1YIuWCNHcOWWU=; b=MWcdn2NakqBTaNaosPWKTwzyJZAhip/6Lwv02ajmSNqaD9SO8KIKR9umBsur6MVnHT iCdlcvBZLyvSqWuT6oV4pbjLRcuLp6i8hQZCgLufsebTvSjRilSYc6emSgSKm5uUEa6u o/VQYXAv9VxC6KJInuvYPV8hTNi5qRUGcNBphXX+LHxOF4vITUzN8iSLHoTtkQV22FLh E1ulQk6nQkew5qkJ3I7dPOSFG2LaAcn+NwJNz7vOvej1Gjqhie4oakl/B/AHeQXArYD8 xpPnF0LcDUSINmlTdfvjGiSm3rn2O+7MGw6dcHNvrZHRfbjezsRc7mKpNBACWqFXK3hB EKfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:in-reply-to:user-agent; bh=PI3FjEQXtQHOgVGkOwuxpveSGGmx7R1YIuWCNHcOWWU=; b=NP8y6XP8yniIgXvCWsb9KshHyJXHcvGF1t5VL3LRASAmRn7Ndp3cxmxh2RMDBIJvuP 8wwt3vwRsAQHn4NLXcDMYlJyKHMeAZqQptkO+N/mMxlhJ/u8+eOBszhbPASszUZ2IrQ5 jzc04H7fqV+fZTLhM7FG+hxQFM33cZidQ9EFLMRm59COHQPdWumYNWJhrYw91dpGET5H pu9HHlHY+KGZ9H4WRwLnKMTyUk4/vPnv7at3vFjlUeVAUunCS6Wu4Qc3jHXYR3NqWQOx RjI2qu3DxcuhleLVsUIrxFUtZLYs96sIge0UNAA5jxhR5HUmY21BzyhF3VPqUXDa+eDY tr/w== X-Gm-Message-State: AEkoouuKiBvdue1yO5+EpfcS72R0hfwiuktfqbXchKDZ4ZLly5HDRQZ10w0vPPqZ6rNZvg== X-Received: by 10.98.54.134 with SMTP id d128mr30267146pfa.150.1469458528622; Mon, 25 Jul 2016 07:55:28 -0700 (PDT) Received: from Karyakshetra ([203.187.238.3]) by smtp.gmail.com with ESMTPSA id cp11sm26614711pac.28.2016.07.25.07.55.27 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 25 Jul 2016 07:55:28 -0700 (PDT) Date: Mon, 25 Jul 2016 20:25:22 +0530 From: Bhaktipriya Shridhar To: Mauro Carvalho Chehab , Geunyoung Kim , Junghak Sung , Hans Verkuil , Inki Dae Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: [PATCH v2 1/2] [media] cx25821: Drop Freeing of Workqueue Message-ID: <8c263ffbbc4cfc9ef95ba0ba6f5dbebf253784c2.1469458280.git.bhaktipriya96@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160725144952.GA11594@Karyakshetra> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Workqueues shouldn't be freed. destroy_workqueue should be used instead. destroy_workqueue safely destroys a workqueue and ensures that all pending work items are done before destroying the workqueue. Signed-off-by: Bhaktipriya Shridhar Acked-by: Tejun Heo --- Changes in v2: None drivers/media/pci/cx25821/cx25821-audio-upstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/pci/cx25821/cx25821-audio-upstream.c b/drivers/media/pci/cx25821/cx25821-audio-upstream.c index 68dbc2d..05bd957 100644 --- a/drivers/media/pci/cx25821/cx25821-audio-upstream.c +++ b/drivers/media/pci/cx25821/cx25821-audio-upstream.c @@ -242,7 +242,7 @@ void cx25821_stop_upstream_audio(struct cx25821_dev *dev) dev->_audioframe_count = 0; dev->_audiofile_status = END_OF_FILE; - kfree(dev->_irq_audio_queues); + destroy_workqueue(dev->_irq_audio_queues); dev->_irq_audio_queues = NULL; kfree(dev->_audiofilename);