From patchwork Wed Sep 20 17:02:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9961879 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7AE5E60208 for ; Wed, 20 Sep 2017 17:03:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 69A8328FDB for ; Wed, 20 Sep 2017 17:03:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5E970291A4; Wed, 20 Sep 2017 17:03:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2AE428FDB for ; Wed, 20 Sep 2017 17:03:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751367AbdITRDH (ORCPT ); Wed, 20 Sep 2017 13:03:07 -0400 Received: from mout.web.de ([212.227.15.3]:51771 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbdITRDF (ORCPT ); Wed, 20 Sep 2017 13:03:05 -0400 Received: from [192.168.1.2] ([77.181.108.184]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M2dxF-1d5Dhr3LZF-00sMcX; Wed, 20 Sep 2017 19:02:54 +0200 Subject: [PATCH 5/5] [media] s2255drv: Delete an unnecessary return statement in five functions From: SF Markus Elfring To: linux-media@vger.kernel.org, Arvind Yadav , Bhumika Goyal , Laurent Pinchart , Mauro Carvalho Chehab , Mike Isely , Sakari Ailus Cc: LKML , kernel-janitors@vger.kernel.org References: <55718a41-d76f-36bf-7197-db92014dcd3c@users.sourceforge.net> Message-ID: <9c75bbfd-ee58-3f97-4fa7-47aa306d1396@users.sourceforge.net> Date: Wed, 20 Sep 2017 19:02:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <55718a41-d76f-36bf-7197-db92014dcd3c@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:fxO7c8KmIZ45bCSoQYoHNLdF79BMp2BrxS9kenCWapXp1f6RQ/j /nzKxR/9M7zcniZOlo8vz1GpxqECyEQ4G9ysa8qi7VM1LUtW6ASLV1huXNpDGtpLBXkipSa tkVQ8IGFOZGNtumJOtl6f1Me/DF7YYe71F1LxTKjDXvkk5jByyK7cAVOS+ls+VYxKeR70z+ r7uwmaaE7vjyF1z2bp0yQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:k2YUUdoTNeg=:x9CSSM/9ybnVS7VEg+VaJz 7U0iFxNSfLSeWEYLArrCYzMoirjodTgoJarRENnKPrSS4ipULyXBhcr6r50gxw00rN2hNRxQj 6E6r7DyR8GeIaHXpaC6rIvxpu6R2PTtVTDXCmOxDfeSdznctvL9+kmOjA9Vkm3GWLRpAxEpRD nTcC8uPM3zixXFKPHkwX8c0vcyblPFtDDKVyGhdZJkUsDN2QDDpQJzsVDKGXBlaqXxGTQtz2d wivEXx7EIPsElViq0/HtaHNyc6IKx6Rd61qSLHCmY2celTQZrKQVrJny+o5TXdpjKNyXGk6TM 3S1ue42qvZuKR42EIirTl4NCzyf2zdWoeleVJW6pKZnFlw5N0+BKr3Pl3ysBk9m1xGlUkGnXj +gPPs8FEoMbbeM3LT5dk47/7vp1SNAyN6LliwTixIa4oL+5R+gzNtb24HyPABBzJAMSZ7GTDL cilX3MitoWb/EBVMYPE1tOvtTNj+wqM3OeIuXG87hJJlUX1QDlsE8dIUmRCFstRUUZHlQghDw eg1TkNSd6ZwTzolLUBUp215Fspc82NB+BRvwzDPO5XPFu1fJANF0X406Ces+xKUb7oYzQoL7A 69hgpLMIww9C7wuy8ObMflebOYfyrs4lsvcwlUdBqLMtBSymLetggMO3FEp1JMTWMdWzXYXK8 N17DOvElH+5si6wMPKmpXomS7I1kEvZyA8nibKAwr/+rLltSoiL5kuqJ6XLbNYZCoGx62vyIG D25mVXVncRCSBdG/t8DB6vYqjJjrtJf2o3e9L8OQttERB1XtJ5YFQmSNLpFmEDfzEETwTJWAw lo5HaXwBuOU017rTe7POnRRrz1M0vZoHo7oLgXluC2V60rDTHU= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Wed, 20 Sep 2017 17:50:36 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected functions. Signed-off-by: Markus Elfring --- drivers/media/usb/s2255/s2255drv.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index 5a5d5ae833ff..2f0e0fafc4e2 100644 --- a/drivers/media/usb/s2255/s2255drv.c +++ b/drivers/media/usb/s2255/s2255drv.c @@ -471,6 +471,5 @@ static void planar422p_to_yuv_packed(const unsigned char *in, out[i + 3] = (fmt == V4L2_PIX_FMT_YUYV) ? *pCb++ : *pY++; } - return; } static void s2255_reset_dsppower(struct s2255_dev *dev) @@ -482,5 +481,4 @@ static void s2255_reset_dsppower(struct s2255_dev *dev) s2255_vendor_req(dev, 0x10, 0x0000, 0x0000, NULL, 0, 1); - return; } /* kickstarts the firmware loading. from probe @@ -1586,6 +1584,5 @@ static void s2255_video_device_release(struct video_device *vdev) if (atomic_dec_and_test(&dev->num_channels)) s2255_destroy(dev); - return; } static const struct video_device template = { @@ -1890,5 +1887,4 @@ static void s2255_read_video_callback(struct s2255_dev *dev, dprintk(dev, 50, "callback read video done\n"); - return; } static long s2255_vendor_req(struct s2255_dev *dev, unsigned char Request, @@ -2205,5 +2201,4 @@ static void s2255_stop_readpipe(struct s2255_dev *dev) dprintk(dev, 4, "%s", __func__); - return; } static void s2255_fwload_start(struct s2255_dev *dev, int reset)