diff mbox

Increase max exposure value to 255 from 26.

Message ID BANLkTikCgTWA92P2Qw4hqyvmQFRZm7+Aog@mail.gmail.com (mailing list archive)
State Under Review
Headers show

Commit Message

Marco Diego Aurélio Mesquita June 4, 2011, 7:38 a.m. UTC
The inline patch increases maximum exposure value from 26 to 255. It
has been tested and works well. Without the patch the captured image
is too dark and can't be improved too much.

Please CC answers as I'm not subscribed to the list.


Signed-off-by: Marco Diego Aurélio Mesquita <marcodiegomesquita@gmail.com>
---
 drivers/media/video/gspca/pac207.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Hans de Goede June 4, 2011, 8:21 a.m. UTC | #1
Hi,

Interesting. I'll go and test this with my 6 or so pac207 cameras,
but first I need to wait till this evening as atm it is too
light to test high exposure settings :)

Regards,

Hans


On 06/04/2011 09:38 AM, Marco Diego Aurélio Mesquita wrote:
> The inline patch increases maximum exposure value from 26 to 255. It
> has been tested and works well. Without the patch the captured image
> is too dark and can't be improved too much.
>
> Please CC answers as I'm not subscribed to the list.
>
>
> Signed-off-by: Marco Diego Aurélio Mesquita<marcodiegomesquita@gmail.com>
> ---
>   drivers/media/video/gspca/pac207.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/gspca/pac207.c
> b/drivers/media/video/gspca/pac207.c
> index 892b454..6a2fb26 100644
> --- a/drivers/media/video/gspca/pac207.c
> +++ b/drivers/media/video/gspca/pac207.c
> @@ -39,7 +39,7 @@ MODULE_LICENSE("GPL");
>   #define PAC207_BRIGHTNESS_DEFAULT	46
>
>   #define PAC207_EXPOSURE_MIN		3
> -#define PAC207_EXPOSURE_MAX		26
> +#define PAC207_EXPOSURE_MAX		255
>   #define PAC207_EXPOSURE_DEFAULT		5 /* power on default: 3 */
>   #define PAC207_EXPOSURE_KNEE		8 /* 4 = 30 fps, 11 = 8, 15 = 6 */
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marco Diego Aurélio Mesquita June 4, 2011, 8:27 p.m. UTC | #2
I think there maybe some different versions of the chip. Whenever I
get a webcam with a pac207, it has the problem described here:
http://ubuntuforums.org/archive/index.php/t-1553690.html

2011/6/4 Hans de Goede <hdegoede@redhat.com>:
> Hi,
>
> Interesting. I'll go and test this with my 6 or so pac207 cameras,
> but first I need to wait till this evening as atm it is too
> light to test high exposure settings :)
>
> Regards,
>
> Hans
>
>
> On 06/04/2011 09:38 AM, Marco Diego Aurélio Mesquita wrote:
>>
>> The inline patch increases maximum exposure value from 26 to 255. It
>> has been tested and works well. Without the patch the captured image
>> is too dark and can't be improved too much.
>>
>> Please CC answers as I'm not subscribed to the list.
>>
>>
>> Signed-off-by: Marco Diego Aurélio Mesquita<marcodiegomesquita@gmail.com>
>> ---
>>  drivers/media/video/gspca/pac207.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/media/video/gspca/pac207.c
>> b/drivers/media/video/gspca/pac207.c
>> index 892b454..6a2fb26 100644
>> --- a/drivers/media/video/gspca/pac207.c
>> +++ b/drivers/media/video/gspca/pac207.c
>> @@ -39,7 +39,7 @@ MODULE_LICENSE("GPL");
>>  #define PAC207_BRIGHTNESS_DEFAULT     46
>>
>>  #define PAC207_EXPOSURE_MIN           3
>> -#define PAC207_EXPOSURE_MAX            26
>> +#define PAC207_EXPOSURE_MAX            255
>>  #define PAC207_EXPOSURE_DEFAULT               5 /* power on default: 3 */
>>  #define PAC207_EXPOSURE_KNEE          8 /* 4 = 30 fps, 11 = 8, 15 = 6 */
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/video/gspca/pac207.c
b/drivers/media/video/gspca/pac207.c
index 892b454..6a2fb26 100644
--- a/drivers/media/video/gspca/pac207.c
+++ b/drivers/media/video/gspca/pac207.c
@@ -39,7 +39,7 @@  MODULE_LICENSE("GPL");
 #define PAC207_BRIGHTNESS_DEFAULT	46

 #define PAC207_EXPOSURE_MIN		3
-#define PAC207_EXPOSURE_MAX		26
+#define PAC207_EXPOSURE_MAX		255
 #define PAC207_EXPOSURE_DEFAULT		5 /* power on default: 3 */
 #define PAC207_EXPOSURE_KNEE		8 /* 4 = 30 fps, 11 = 8, 15 = 6 */