From patchwork Tue Jul 23 15:50:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 2832057 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C17A4C0319 for ; Tue, 23 Jul 2013 15:50:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 99B0520205 for ; Tue, 23 Jul 2013 15:50:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F13C20204 for ; Tue, 23 Jul 2013 15:50:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932964Ab3GWPu2 (ORCPT ); Tue, 23 Jul 2013 11:50:28 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:59858 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932481Ab3GWPu1 convert rfc822-to-8bit (ORCPT ); Tue, 23 Jul 2013 11:50:27 -0400 Received: by mail-we0-f177.google.com with SMTP id m46so546913wev.8 for ; Tue, 23 Jul 2013 08:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=6gTvOdzrNWjS+2HII3mwLaQ+snRBG9/KH/7bffE0WtA=; b=IyQ82a7x9PhcT97l9bfEk1nSt+r1GZ0uhdtHy3fy3+QccDB/kxNBLTGlswnYMhU5V5 Fua1d0d6kxBPsGm3JlI2hB2BOVS2oKuQx5C6qGPPoOL7cUbGdtpx9NUahqgnvWtzU9IY 2lHOg8DNFYVVEkfJvyEk9BIdN550Wn66eVOFbxd18clDKrvJBeGk5e2oar89DZ2g2j30 xCg2giUrX3yuhUwdENOwgTzU4eJHWaniWH/SeKv7upwEv4SrRjwzTo97JzKhmFwKK6Pn TyoePsnVhpMrex83JmP4FWmiS/EBfiojC/ARd+IMF+GzF03QVaSvXTejciEqPqLNfEaX EwjA== X-Received: by 10.180.85.8 with SMTP id d8mr22432819wiz.13.1374594626310; Tue, 23 Jul 2013 08:50:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.120.232 with HTTP; Tue, 23 Jul 2013 08:50:06 -0700 (PDT) In-Reply-To: <1374516287-7638-5-git-send-email-s.nawrocki@samsung.com> References: <1374516287-7638-1-git-send-email-s.nawrocki@samsung.com> <1374516287-7638-5-git-send-email-s.nawrocki@samsung.com> From: Prabhakar Lad Date: Tue, 23 Jul 2013 21:20:06 +0530 Message-ID: Subject: Re: [PATCH RFC 4/5] V4L2: Rename subdev field of struct v4l2_async_notifier To: Sylwester Nawrocki Cc: linux-media@vger.kernel.org, g.liakhovetski@gmx.de, laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl, kyungmin.park@samsung.com Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Sylwester, On Mon, Jul 22, 2013 at 11:34 PM, Sylwester Nawrocki wrote: > This is a purely cosmetic change. Since the 'subdev' member > points to an array of subdevs it seems more intuitive to name > it in plural form. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > --- > drivers/media/platform/soc_camera/soc_camera.c | 2 +- > drivers/media/v4l2-core/v4l2-async.c | 2 +- > include/media/v4l2-async.h | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > can you include the following changes in the same patch ? so that git bisect doesn’t break. (maybe you need to rebase the patches on http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/for-v3.12) Regards, --Prabhakar Lad --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index b11d7a7..7fbde6d 100644 --- a/drivers/media/platform/davinci/vpif_capture.c +++ b/drivers/media/platform/davinci/vpif_capture.c @@ -2168,7 +2168,7 @@ static __init int vpif_probe(struct platform_device *pdev) } vpif_probe_complete(); } else { - vpif_obj.notifier.subdev = vpif_obj.config->asd; + vpif_obj.notifier.subdevs = vpif_obj.config->asd; vpif_obj.notifier.num_subdevs = vpif_obj.config->asd_sizes[0]; vpif_obj.notifier.bound = vpif_async_bound; vpif_obj.notifier.complete = vpif_async_complete; diff --git a/drivers/media/platform/davinci/vpif_display.c b/drivers/media/platform/davinci/vpif_display.c index c2ff067..6336dfc 100644 --- a/drivers/media/platform/davinci/vpif_display.c +++ b/drivers/media/platform/davinci/vpif_display.c @@ -1832,7 +1832,7 @@ static __init int vpif_probe(struct platform_device *pdev) } vpif_probe_complete(); } else { - vpif_obj.notifier.subdev = vpif_obj.config->asd; + vpif_obj.notifier.subdevs = vpif_obj.config->asd; vpif_obj.notifier.num_subdevs = vpif_obj.config->asd_sizes[0]; vpif_obj.notifier.bound = vpif_async_bound; vpif_obj.notifier.complete = vpif_async_complete;