From patchwork Sat Nov 11 19:06:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Caumont X-Patchwork-Id: 10054481 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1DEE960365 for ; Sat, 11 Nov 2017 19:06:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2B062958A for ; Sat, 11 Nov 2017 19:06:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E3FB829A16; Sat, 11 Nov 2017 19:06:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F9422958A for ; Sat, 11 Nov 2017 19:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751787AbdKKTGk (ORCPT ); Sat, 11 Nov 2017 14:06:40 -0500 Received: from mail-qt0-f169.google.com ([209.85.216.169]:49215 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751757AbdKKTGk (ORCPT ); Sat, 11 Nov 2017 14:06:40 -0500 Received: by mail-qt0-f169.google.com with SMTP id p44so5022424qtj.6 for ; Sat, 11 Nov 2017 11:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2gQC8F8eofrsbheDB23s6e0WbGqHcGo6Wi+XXpCp20Q=; b=scRosw5bl58T29246cUevQSZsm0Kc6QcKUhujyM/5e4yCTHbr7vGYum62uHHcRrLki Fs1J8IfTyVBRuWHzs2xHe3vMS+5eCraAYdIpiqgQpZABsO5Z5wW5pLTJwBNnFbTzi9eA bMTep8OqTOTaXYfCko91sykDtkZ7fqHFq6gp4F7SYubEbszOGjIFI7VmdMWsjaG2ipmC WdW2sRnr84e36DQgj+GPEBI5ydNNJFKBao2Ff/ziShE1c1r3gj8U1vVixpQhpYlUug7b P+pDfxf50yHfYKh+Rk6iGThoES/KGBvjaF83IV8a7Gd1j7ZESquRB1aPOoz1Cd/W5qB4 5UyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2gQC8F8eofrsbheDB23s6e0WbGqHcGo6Wi+XXpCp20Q=; b=BNY/PJfzb7nwncU78XCzYRRHjn/ZyZBvOVJiufXarS/ZkC2+GRDGI2W9K/ZRJRKFku qOPJC9Ml0oY/DnNPtsgqHbPm0J+Y7Mbli5H+/rbEgPGPplVkw+JeSsGPCVjiSs2EzamJ euk0MrZx27PTCqmzKLXIJ5Rx3OmQwNpZ7rl6H/6vE4Y4vXAEP40bHqqJZj+Dhe2sjdcU 47SJMgHrHbeVJeKktGsFt6QKZO5Nkh3ElSEvghBNVGb8s3k9g0hhf/iyk0lY1ZvTgV02 5KSvvFLqDGLj9lF/wBO9+lm/b5HxU1W5Ybc2eHavgmLFCoPveN8lbnbM4UGW96Xh05L5 3C2w== X-Gm-Message-State: AJaThX6JYjQBOw6PdTiRWsZe56DiOCfdCkxZDZL2twTIqSZG+WfrCGJ4 k19Or7x70PRLGXd6ylk87Y/SYmxkmqbXX0ZhJODWeA== X-Google-Smtp-Source: AGs4zMYOC7LibK/DxEhs13mtIH7CQ5HF7vAuAEYCgyL4ba71lKOl3Uosa4ultZjPAxSiOvqxl5sul/IRQHmyN3ZCeY0= X-Received: by 10.200.27.225 with SMTP id m30mr4475309qtk.260.1510427199273; Sat, 11 Nov 2017 11:06:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.190.200 with HTTP; Sat, 11 Nov 2017 11:06:38 -0800 (PST) In-Reply-To: <20171111180159.fb33mc2t467ygfqw@gofer.mess.org> References: <20171023094305.nxrxsqjrrwtygupc@gofer.mess.org> <20171023185750.5m5qo575myogzbhz@gofer.mess.org> <20171029193121.p2q6dxxz376cpx5y@gofer.mess.org> <20171107084245.47dce306@vento.lan> <20171111105643.ozwukzmdhalxhoho@gofer.mess.org> <20171111180159.fb33mc2t467ygfqw@gofer.mess.org> From: Laurent Caumont Date: Sat, 11 Nov 2017 20:06:38 +0100 Message-ID: Subject: Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10 To: Sean Young Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Sean, I hope this one will be okay. 2017-11-11 19:01 GMT+01:00 Sean Young : > Hi Laurent, > > On Sat, Nov 11, 2017 at 06:53:54PM +0100, Laurent Caumont wrote: >> Hi Sean, >> >> I just realized that files in media_build/linux/driver are not >> associate with a git repository. They are retrieved by the build >> command. >> So, I cloned the linux-stable repository to generate the patch. > > Great, thank you. > > We need a Signed-off-by: line to accept your patch, see part 11 of > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > Thanks, > > Sean From bf48cb8988a0335038e8df1a40f1d1b2cf4225d5 Mon Sep 17 00:00:00 2001 From: Laurent Caumont Date: Sat, 11 Nov 2017 18:44:46 +0100 Subject: [PATCH] media: dvb: i2c transfers over usb - use kmalloc instead stack Signed-off-by: Laurent Caumont --- drivers/media/usb/dvb-usb/dibusb-common.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dibusb-common.c b/drivers/media/usb/dvb-usb/dibusb-common.c index 8207e690..e1c31381 100644 --- a/drivers/media/usb/dvb-usb/dibusb-common.c +++ b/drivers/media/usb/dvb-usb/dibusb-common.c @@ -223,8 +223,26 @@ EXPORT_SYMBOL(dibusb_i2c_algo); int dibusb_read_eeprom_byte(struct dvb_usb_device *d, u8 offs, u8 *val) { - u8 wbuf[1] = { offs }; - return dibusb_i2c_msg(d, 0x50, wbuf, 1, val, 1); + u8 *wbuf; + u8 *rbuf; + int rc; + + rbuf = kmalloc(1, GFP_KERNEL); + if (!rbuf) + return -ENOMEM; + + wbuf = kmalloc(1, GFP_KERNEL); + if (!wbuf) + return -ENOMEM; + + *wbuf = offs; + + rc = dibusb_i2c_msg(d, 0x50, wbuf, 1, rbuf, 1); + kfree(wbuf); + *val = *rbuf; + kfree(rbuf); + + return rc; } EXPORT_SYMBOL(dibusb_read_eeprom_byte); -- 2.14.1