From patchwork Thu Jul 14 09:16:30 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ming Lei X-Patchwork-Id: 974672 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6E9GbJI018225 for ; Thu, 14 Jul 2011 09:16:37 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606Ab1GNJQc (ORCPT ); Thu, 14 Jul 2011 05:16:32 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:57007 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751510Ab1GNJQb convert rfc822-to-8bit (ORCPT ); Thu, 14 Jul 2011 05:16:31 -0400 Received: by gyh3 with SMTP id 3so23033gyh.19 for ; Thu, 14 Jul 2011 02:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=CYLrlK66Pw5pei9TnG/C9bM5zCiHwEcEniiHdZdq3sQ=; b=OY8prPeR8RGNYtTtK/o2OK+ZKrW5kh4J4chryuDei925UhH8qGX18bDVnGtPN7TuQ/ eRsJCig7QZApJ4ViC/EgaI5zvxSsgEqJSEamFMHvqPaLlC23tgiSvbl+WZ33XwLDuno4 xciNm5shpVMXN0KC4DXMec19r0NyquCrRskGA= MIME-Version: 1.0 Received: by 10.236.176.36 with SMTP id a24mr2693326yhm.284.1310634990647; Thu, 14 Jul 2011 02:16:30 -0700 (PDT) Received: by 10.236.70.101 with HTTP; Thu, 14 Jul 2011 02:16:30 -0700 (PDT) In-Reply-To: References: Date: Thu, 14 Jul 2011 17:16:30 +0800 Message-ID: Subject: Re: [PATCH] uvcvideo: add fix suspend/resume quirk for Microdia camera From: Ming Lei To: Alan Stern Cc: Laurent Pinchart , Ming Lei , linux-media@vger.kernel.org, linux-usb@vger.kernel.org, Jeremy Kerr , Mauro Carvalho Chehab Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 14 Jul 2011 09:16:37 +0000 (UTC) Hi, On Wed, Jul 13, 2011 at 11:59 PM, Alan Stern wrote: > On Wed, 13 Jul 2011, Ming Lei wrote: >> Almost same. > > Come on.  "Almost same" means they are different.  That difference is > clearly the important thing you need to track down. I didn't say "entirely same" because we can't trace the packets via usbmon during system resume, but we can do it during runtime resume. In fact, except for above, the packets captured from interrupt ep and control ep are completely same. Also all functions in uvc (rpm, system)resume path return successfully. > >>  If I add USB_QUIRK_RESET_RESUME quirk for the device, >> the stream data will not be received from the device in runtime pm case, >> same with that in system suspend. > > uvcvideo should be able to reinitialize the device so that it works > correctly following a reset.  If the device doesn't work then uvcvideo > has a bug in its reset_resume handler. This also indicates the usb reset during resume does make the uvc device broken. >> Maybe buggy BIOS makes root hub send reset signal to the device during >> system suspend time, not sure... > > That's entirely possible. The below quirk fixes the issue now. thanks, diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 81ce6a8..93c6fa2 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -82,6 +82,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* Broadcom BCM92035DGROM BT dongle */ { USB_DEVICE(0x0a5c, 0x2021), .driver_info = USB_QUIRK_RESET_RESUME }, + /* Microdia uvc camera */ + { USB_DEVICE(0x0c45, 0x6437), .driver_info = USB_QUIRK_RESET_MORPHS }, + /* Action Semiconductor flash disk */ { USB_DEVICE(0x10d6, 0x2200), .driver_info = USB_QUIRK_STRING_FETCH_255 },