From patchwork Sat Jul 14 22:29:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Steven Toth X-Patchwork-Id: 1198271 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 78DF93FD4F for ; Sat, 14 Jul 2012 22:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752165Ab2GNW3y (ORCPT ); Sat, 14 Jul 2012 18:29:54 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:41391 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310Ab2GNW3x convert rfc822-to-8bit (ORCPT ); Sat, 14 Jul 2012 18:29:53 -0400 Received: by obbuo13 with SMTP id uo13so7031102obb.19 for ; Sat, 14 Jul 2012 15:29:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=JpgSTmsX2OzS5XvpP2WvHgoCatrLG1B5L+5zKk+y+Jc=; b=HJH3sqZVdWb7Z6jzFno94w8cTmtNchTgYQHrhACN0iVhX8/20mSFqwWRuY/71XZ76N ZtRiJRnrHy4TSm6dKfl9WC1EKPnoxhdCrJmPkOpAvDrGnm88sG2Wz5QunxojpoK+ORWM In2jEipptGH8srVAzgx2D6M+WbNAEcS1XvFZANv4Us57VLHE5tY5WD4m1gV8juXMErDX bu3/doVQKS3Egl6JmQxyIzw1MZ1+M4nT4K7qE9XLrxFBBheqEYND0cKwSZfBWjUsSlEF 6QbfO66eN1ZnMKinjfKZVVwRqqz4njiZexCjyjrVV/TxrUlb4ivHNVzKIs/wcJTxber4 T2oA== MIME-Version: 1.0 Received: by 10.50.181.232 with SMTP id dz8mr2131663igc.72.1342304992496; Sat, 14 Jul 2012 15:29:52 -0700 (PDT) Received: by 10.64.145.39 with HTTP; Sat, 14 Jul 2012 15:29:52 -0700 (PDT) Date: Sat, 14 Jul 2012 18:29:52 -0400 Message-ID: Subject: staging/for_v3.6 is currently broken From: Steven Toth To: Mauro Chehab Cc: Linux-Media X-Gm-Message-State: ALoCoQmj3VQ3C5EvQ97b9Bcpv4/ye46RRfrwmBQllS+uiT2M6/xVeIzDzkSyCcVEF+wi8NQERFMu Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Looks like the new union in v4l2_ioctl_info breaks things. -bash-4.1$ make -j6 make[1]: Nothing to be done for `all'. CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CHK include/generated/compile.h CC drivers/media/video/v4l2-ioctl.o drivers/media/video/v4l2-ioctl.c:1848:517: error: unknown field ‘func’ specified in initializer drivers/media/video/v4l2-ioctl.c:1848:517: warning: missing braces around initializer drivers/media/video/v4l2-ioctl.c:1848:517: warning: (near initialization for ‘v4l2_ioctls[0].’) drivers/media/video/v4l2-ioctl.c:1848:517: warning: initialization makes integer from pointer without a cast drivers/media/video/v4l2-ioctl.c:1849:644: error: unknown field ‘func’ specified in initializer drivers/media/video/v4l2-ioctl.c:1849:644: warning: initialization makes integer from pointer without a cast Removing the union and the code compiles, although that probably wasn't the original authors intension. FYI diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 70e0efb..1f090c4 100644 --- a/drivers/media/video/v4l2-ioctl.c +++ b/drivers/media/video/v4l2-ioctl.c @@ -1802,11 +1802,9 @@ struct v4l2_ioctl_info { unsigned int ioctl; u32 flags; const char * const name; - union { u32 offset; int (*func)(const struct v4l2_ioctl_ops *ops, struct file *file, void *fh, void *p); - }; void (*debug)(const void *arg, bool write_only); };