| Message ID | CAPgLHd-EpQB2HjpH6pGnDLzvLUyKYSmyPfqQyCWa7CPz0V9d=g@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Apr 09, 2013 at 05:43:09PM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Since rc_unregister_device() frees its argument, the subsequently > call to rc_free_device() on the same variable will cause a double > free bug. Fix by set argument to NULL, thus when fall through to > rc_free_device(), nothing will be done there. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/media/rc/ttusbir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c > index cf0d47f..891762d 100644 > --- a/drivers/media/rc/ttusbir.c > +++ b/drivers/media/rc/ttusbir.c > @@ -347,6 +347,7 @@ static int ttusbir_probe(struct usb_interface *intf, > return 0; > out3: > rc_unregister_device(rc); > + rc = NULL; > out2: > led_classdev_unregister(&tt->led); > out: The patch is right, so thanks for that. However, some else has beaten you to it, I'm afraid: http://www.spinics.net/lists/linux-media/msg62058.html I guess it's up Mauro to decide which one to accept. Sean -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c index cf0d47f..891762d 100644 --- a/drivers/media/rc/ttusbir.c +++ b/drivers/media/rc/ttusbir.c @@ -347,6 +347,7 @@ static int ttusbir_probe(struct usb_interface *intf, return 0; out3: rc_unregister_device(rc); + rc = NULL; out2: led_classdev_unregister(&tt->led); out: