diff mbox

S4 hang with uvcvideo causing "Unlink after no-IRQ? Controller is probably using the wrong IRQ."

Message ID Pine.LNX.4.44L0.0903131647500.5149-100000@iolanthe.rowland.org (mailing list archive)
State RFC
Headers show

Commit Message

Alan Stern March 13, 2009, 8:50 p.m. UTC 
On Fri, 13 Mar 2009, Brandon Philips wrote:

> On 14:03 Fri 13 Mar 2009, Alan Stern wrote:
> > On Fri, 13 Mar 2009, Brandon Philips wrote:
> > 
> > > > Okay, not much information there but it's a start.  Here's a more 
> > > > informative patch to try instead.
> > > 
> > > Here is the log:
> > >  http://ifup.org/~philips/467317/pearl-alan-debug-2.log
> > 
> > I still can't tell what's happening.  Here's yet another patch.
> 
> http://ifup.org/~philips/467317/pearl-alan-debug-3.log

I think I see the problem; the patch below is an attempted fix.
Hopefully it will get your system working.

Alan Stern




--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Brandon Philips March 16, 2009, 4:44 p.m. UTC | #1 
On 16:50 Fri 13 Mar 2009, Alan Stern wrote:
> On Fri, 13 Mar 2009, Brandon Philips wrote:
> 
> > On 14:03 Fri 13 Mar 2009, Alan Stern wrote:
> > > On Fri, 13 Mar 2009, Brandon Philips wrote:
> > > 
> > > > > Okay, not much information there but it's a start.  Here's a more 
> > > > > informative patch to try instead.
> > > > 
> > > > Here is the log:
> > > >  http://ifup.org/~philips/467317/pearl-alan-debug-2.log
> > > 
> > > I still can't tell what's happening.  Here's yet another patch.
> > 
> > http://ifup.org/~philips/467317/pearl-alan-debug-3.log
> 
> I think I see the problem; the patch below is an attempted fix.
> Hopefully it will get your system working.

That fixes it, thanks. This was originally found in a 2.6.27 based
Kernel so the fix can go off to stable@ too.

Tested-by: Brandon Philips <bphilips@suse.de>

> Index: usb-2.6/drivers/usb/host/ehci-q.c
> ===================================================================
> --- usb-2.6.orig/drivers/usb/host/ehci-q.c
> +++ usb-2.6/drivers/usb/host/ehci-q.c
> @@ -1127,7 +1127,7 @@ static void start_unlink_async (struct e
>  	prev->qh_next = qh->qh_next;
>  	wmb ();
>  
> -	if (unlikely (ehci_to_hcd(ehci)->state == HC_STATE_HALT)) {
> +	if (unlikely(!HC_IS_RUNNING(ehci_to_hcd(ehci)->state))) {
>  		/* if (unlikely (qh->reclaim != 0))
>  		 *	this will recurse, probably not much
>  		 */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

Index: usb-2.6/drivers/usb/host/ehci-q.c
===================================================================
--- usb-2.6.orig/drivers/usb/host/ehci-q.c
+++ usb-2.6/drivers/usb/host/ehci-q.c
@@ -1127,7 +1127,7 @@  static void start_unlink_async (struct e
 	prev->qh_next = qh->qh_next;
 	wmb ();
 
-	if (unlikely (ehci_to_hcd(ehci)->state == HC_STATE_HALT)) {
+	if (unlikely(!HC_IS_RUNNING(ehci_to_hcd(ehci)->state))) {
 		/* if (unlikely (qh->reclaim != 0))
 		 *	this will recurse, probably not much
 		 */