From patchwork Fri Mar 13 20:50:04 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Stern X-Patchwork-Id: 11844 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2DKo9l9017908 for ; Fri, 13 Mar 2009 20:50:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbZCMUuI (ORCPT ); Fri, 13 Mar 2009 16:50:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753566AbZCMUuI (ORCPT ); Fri, 13 Mar 2009 16:50:08 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:34373 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751549AbZCMUuH (ORCPT ); Fri, 13 Mar 2009 16:50:07 -0400 Received: (qmail 5585 invoked by uid 2102); 13 Mar 2009 16:50:04 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 13 Mar 2009 16:50:04 -0400 Date: Fri, 13 Mar 2009 16:50:04 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Brandon Philips cc: Greg KH , , , Subject: Re: S4 hang with uvcvideo causing "Unlink after no-IRQ? Controller is probably using the wrong IRQ." In-Reply-To: <20090313194647.GC21008@jenkins.ifup.org> Message-ID: MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, 13 Mar 2009, Brandon Philips wrote: > On 14:03 Fri 13 Mar 2009, Alan Stern wrote: > > On Fri, 13 Mar 2009, Brandon Philips wrote: > > > > > > Okay, not much information there but it's a start. Here's a more > > > > informative patch to try instead. > > > > > > Here is the log: > > > http://ifup.org/~philips/467317/pearl-alan-debug-2.log > > > > I still can't tell what's happening. Here's yet another patch. > > http://ifup.org/~philips/467317/pearl-alan-debug-3.log I think I see the problem; the patch below is an attempted fix. Hopefully it will get your system working. Alan Stern Tested-by: Brandon Philips --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: usb-2.6/drivers/usb/host/ehci-q.c =================================================================== --- usb-2.6.orig/drivers/usb/host/ehci-q.c +++ usb-2.6/drivers/usb/host/ehci-q.c @@ -1127,7 +1127,7 @@ static void start_unlink_async (struct e prev->qh_next = qh->qh_next; wmb (); - if (unlikely (ehci_to_hcd(ehci)->state == HC_STATE_HALT)) { + if (unlikely(!HC_IS_RUNNING(ehci_to_hcd(ehci)->state))) { /* if (unlikely (qh->reclaim != 0)) * this will recurse, probably not much */