From patchwork Mon Mar 30 14:55:25 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 15138 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2UEtI3X008556 for ; Mon, 30 Mar 2009 14:55:18 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751293AbZC3OzS (ORCPT ); Mon, 30 Mar 2009 10:55:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751454AbZC3OzR (ORCPT ); Mon, 30 Mar 2009 10:55:17 -0400 Received: from mail.gmx.net ([213.165.64.20]:51049 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751013AbZC3OzQ (ORCPT ); Mon, 30 Mar 2009 10:55:16 -0400 Received: (qmail invoked by alias); 30 Mar 2009 14:55:12 -0000 Received: from p57BD1AB0.dip0.t-ipconnect.de (EHLO axis700.grange) [87.189.26.176] by mail.gmx.net (mp013) with SMTP; 30 Mar 2009 16:55:12 +0200 X-Authenticated: #20450766 X-Provags-ID: V01U2FsdGVkX19HIsFTb2FHSuGlYamLI+j6E/D2kGnyH9nfV7Kax+ 5CzSm4+Nw5Nbsk Received: from lyakh (helo=localhost) by axis700.grange with local-esmtp (Exim 4.63) (envelope-from ) id 1LoItZ-00020O-7Q for linux-media@vger.kernel.org; Mon, 30 Mar 2009 16:55:25 +0200 Date: Mon, 30 Mar 2009 16:55:25 +0200 (CEST) From: Guennadi Liakhovetski To: Linux Media Mailing List Subject: [PATCH] mt9m001: fix advertised pixel clock polarity Message-ID: MIME-Version: 1.0 X-Y-GMX-Trusted: 0 X-FuHaFi: 0.54 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org MT9M001 datasheet says, that the data is ready on the falling edge of the pixel clock, but the driver wrongly sets the SOCAM_PCLK_SAMPLE_RISING flag. Changing this doesn't seem to produce any visible difference, still, it is better to comply to the datasheet. Reported-by: Sascha Oppermann Signed-off-by: Guennadi Liakhovetski --- Objections? drivers/media/video/mt9m001.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/mt9m001.c b/drivers/media/video/mt9m001.c index fa7e509..684f62f 100644 --- a/drivers/media/video/mt9m001.c +++ b/drivers/media/video/mt9m001.c @@ -207,7 +207,7 @@ static unsigned long mt9m001_query_bus_param(struct soc_camera_device *icd) struct mt9m001 *mt9m001 = container_of(icd, struct mt9m001, icd); struct soc_camera_link *icl = mt9m001->client->dev.platform_data; /* MT9M001 has all capture_format parameters fixed */ - unsigned long flags = SOCAM_PCLK_SAMPLE_RISING | + unsigned long flags = SOCAM_PCLK_SAMPLE_FALLING | SOCAM_HSYNC_ACTIVE_HIGH | SOCAM_VSYNC_ACTIVE_HIGH | SOCAM_DATA_ACTIVE_HIGH | SOCAM_MASTER;