diff mbox

[V3] Add camera (CSI) driver for MX1

Message ID Pine.LNX.4.64.0904031252210.4729@axis700.grange (mailing list archive)
State RFC
Headers show

Commit Message

Guennadi Liakhovetski April 3, 2009, 10:54 a.m. UTC 
On Fri, 3 Apr 2009, Darius Augulis wrote:

> Guennadi Liakhovetski wrote:
> > Ok, we're almost there:-) Should be the last iteration.
> > 
> > On Fri, 3 Apr 2009, Darius Augulis wrote:
> > 
> >   
> > > From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
> > > 
> > > Changelog since V2:
> > > - My signed-off line added
> > > - Makefile updated
> > > - .init and .exit removed from pdata
> > > - includes sorted
> > > - Video memory limit added
> > > - Pointers in free_buffer() fixed
> > > - Indentation fixed
> > > - Spinlocks added
> > > - PM implementation removed
> > > - Added missed clk_put()
> > > - pdata test added
> > > - CSI device renamed
> > > - Platform flags fixed
> > > - "i.MX" replaced by "MX1" in debug prints
> > >     
> > 
> > I usually put such changelogs below the "---" line, so it doesn't appear in
> > the git commit message, and here you just put a short description of the
> > patch.
> > 
> >   
> > > Signed-off-by: Darius Augulis <augulis.darius@gmail.com>
> > > Signed-off-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
> > > ---
> > >     
> > 
> > [snip]
> > 
> >   
> > > diff --git a/arch/arm/plat-mxc/include/mach/memory.h
> > > b/arch/arm/plat-mxc/include/mach/memory.h
> > > index e0783e6..7113b3e 100644
> > > --- a/arch/arm/plat-mxc/include/mach/memory.h
> > > +++ b/arch/arm/plat-mxc/include/mach/memory.h
> > > @@ -24,4 +24,12 @@
> > >  #define PHYS_OFFSET		UL(0x80000000)
> > >  #endif
> > >  +#if defined(CONFIG_MX1_VIDEO)
> > >     
> > 
> > This #ifdef is not needed any more now, the file is not compiled if
> > CONFIG_MX1_VIDEO is not defined.
> >   
> this header file is included by arch/arm/include/asm/memory.h
> By default dma bufer size is only 2Mbytes. If we remove this ifdef, this bufer
> will be increased to re-defined size.
> Therefore I suggest to leave this ifdef.

Ouch, sorry, I meant this one:

the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Darius April 3, 2009, 11:22 a.m. UTC | #1 
Guennadi Liakhovetski wrote:
> On Fri, 3 Apr 2009, Darius Augulis wrote:
> 
>> Guennadi Liakhovetski wrote:
>>> Ok, we're almost there:-) Should be the last iteration.
>>>
>>> On Fri, 3 Apr 2009, Darius Augulis wrote:
>>>
>>>   
>>>> From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
>>>>
>>>> Changelog since V2:
>>>> - My signed-off line added
>>>> - Makefile updated
>>>> - .init and .exit removed from pdata
>>>> - includes sorted
>>>> - Video memory limit added
>>>> - Pointers in free_buffer() fixed
>>>> - Indentation fixed
>>>> - Spinlocks added
>>>> - PM implementation removed
>>>> - Added missed clk_put()
>>>> - pdata test added
>>>> - CSI device renamed
>>>> - Platform flags fixed
>>>> - "i.MX" replaced by "MX1" in debug prints
>>>>     
>>> I usually put such changelogs below the "---" line, so it doesn't appear in
>>> the git commit message, and here you just put a short description of the
>>> patch.

I'm using Stgit and I can't put anything below --- with "stg edit", because Stgit automatically removes everything what is below ---.
I don't want to send patches manually, so I will add changelog in the reply message.

>>>
>>>   
>>>> Signed-off-by: Darius Augulis <augulis.darius@gmail.com>
>>>> Signed-off-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
>>>> ---
>>>>     
>>> [snip]
>>>
>>>   
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-mx1/ksym_mx1.c b/arch/arm/mach-mx1/ksym_mx1.c
new file mode 100644
index 0000000..9f1116b
--- /dev/null
+++ b/arch/arm/mach-mx1/ksym_mx1.c
@@ -0,0 +1,20 @@ 
+/*
+ * Exported ksyms of ARCH_MX1
+ *
+ * Copyright (C) 2008, Darius Augulis <augulis.darius@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+
+#if defined(CONFIG_MX1_VIDEO)

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in