From patchwork Fri Apr 3 10:54:30 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 16091 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n33AtkAM012949 for ; Fri, 3 Apr 2009 10:55:46 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761030AbZDCKy2 (ORCPT ); Fri, 3 Apr 2009 06:54:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762203AbZDCKy1 (ORCPT ); Fri, 3 Apr 2009 06:54:27 -0400 Received: from mail.gmx.net ([213.165.64.20]:60001 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1761030AbZDCKy0 (ORCPT ); Fri, 3 Apr 2009 06:54:26 -0400 Received: (qmail invoked by alias); 03 Apr 2009 10:54:23 -0000 Received: from p57BD1713.dip0.t-ipconnect.de (EHLO axis700.grange) [87.189.23.19] by mail.gmx.net (mp018) with SMTP; 03 Apr 2009 12:54:23 +0200 X-Authenticated: #20450766 X-Provags-ID: V01U2FsdGVkX1+hBvxRivuhIua+NMW9DfzgdWrGTkd+Nort5IsBhv nRWluYbs/+zLEy Received: from lyakh (helo=localhost) by axis700.grange with local-esmtp (Exim 4.63) (envelope-from ) id 1Lph2c-0001k3-4j; Fri, 03 Apr 2009 12:54:30 +0200 Date: Fri, 3 Apr 2009 12:54:30 +0200 (CEST) From: Guennadi Liakhovetski To: Darius Augulis cc: Linux Media Mailing List , Sascha Hauer , paulius.zaleckas@teltonika.lt Subject: Re: [PATCH V3] Add camera (CSI) driver for MX1 In-Reply-To: <49D5E8A5.1080608@gmail.com> Message-ID: References: <20090403080923.3222.80609.stgit@localhost.localdomain> <49D5E8A5.1080608@gmail.com> MIME-Version: 1.0 X-Y-GMX-Trusted: 0 X-FuHaFi: 0.5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, 3 Apr 2009, Darius Augulis wrote: > Guennadi Liakhovetski wrote: > > Ok, we're almost there:-) Should be the last iteration. > > > > On Fri, 3 Apr 2009, Darius Augulis wrote: > > > > > > > From: Paulius Zaleckas > > > > > > Changelog since V2: > > > - My signed-off line added > > > - Makefile updated > > > - .init and .exit removed from pdata > > > - includes sorted > > > - Video memory limit added > > > - Pointers in free_buffer() fixed > > > - Indentation fixed > > > - Spinlocks added > > > - PM implementation removed > > > - Added missed clk_put() > > > - pdata test added > > > - CSI device renamed > > > - Platform flags fixed > > > - "i.MX" replaced by "MX1" in debug prints > > > > > > > I usually put such changelogs below the "---" line, so it doesn't appear in > > the git commit message, and here you just put a short description of the > > patch. > > > > > > > Signed-off-by: Darius Augulis > > > Signed-off-by: Paulius Zaleckas > > > --- > > > > > > > [snip] > > > > > > > diff --git a/arch/arm/plat-mxc/include/mach/memory.h > > > b/arch/arm/plat-mxc/include/mach/memory.h > > > index e0783e6..7113b3e 100644 > > > --- a/arch/arm/plat-mxc/include/mach/memory.h > > > +++ b/arch/arm/plat-mxc/include/mach/memory.h > > > @@ -24,4 +24,12 @@ > > > #define PHYS_OFFSET UL(0x80000000) > > > #endif > > > +#if defined(CONFIG_MX1_VIDEO) > > > > > > > This #ifdef is not needed any more now, the file is not compiled if > > CONFIG_MX1_VIDEO is not defined. > > > this header file is included by arch/arm/include/asm/memory.h > By default dma bufer size is only 2Mbytes. If we remove this ifdef, this bufer > will be increased to re-defined size. > Therefore I suggest to leave this ifdef. Ouch, sorry, I meant this one: the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-mx1/ksym_mx1.c b/arch/arm/mach-mx1/ksym_mx1.c new file mode 100644 index 0000000..9f1116b --- /dev/null +++ b/arch/arm/mach-mx1/ksym_mx1.c @@ -0,0 +1,20 @@ +/* + * Exported ksyms of ARCH_MX1 + * + * Copyright (C) 2008, Darius Augulis + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include +#include + +#if defined(CONFIG_MX1_VIDEO) Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer -- To unsubscribe from this list: send the line "unsubscribe linux-media" in