From patchwork Tue Apr 21 07:22:38 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 19129 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3L7Nd1n028335 for ; Tue, 21 Apr 2009 07:23:39 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752334AbZDUHWi (ORCPT ); Tue, 21 Apr 2009 03:22:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753947AbZDUHWh (ORCPT ); Tue, 21 Apr 2009 03:22:37 -0400 Received: from mail.gmx.net ([213.165.64.20]:60542 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751534AbZDUHWg (ORCPT ); Tue, 21 Apr 2009 03:22:36 -0400 Received: (qmail invoked by alias); 21 Apr 2009 07:22:34 -0000 Received: from p57BD18C8.dip0.t-ipconnect.de (EHLO axis700.grange) [87.189.24.200] by mail.gmx.net (mp067) with SMTP; 21 Apr 2009 09:22:34 +0200 X-Authenticated: #20450766 X-Provags-ID: V01U2FsdGVkX1+TfQsm4eyTDW6PdQO8ZO9ipIXjVU/ntUNEmBKTSK MyQJtUdTNcqXPp Received: from lyakh (helo=localhost) by axis700.grange with local-esmtp (Exim 4.63) (envelope-from ) id 1LwAJS-0001oA-SM; Tue, 21 Apr 2009 09:22:38 +0200 Date: Tue, 21 Apr 2009 09:22:38 +0200 (CEST) From: Guennadi Liakhovetski To: Linux Media Mailing List , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org cc: Mauro Carvalho Chehab , Greg KH , khali@linux-fr.org, Hans Verkuil Subject: [PATCH] drivers: move media after i2c Message-ID: MIME-Version: 1.0 X-Y-GMX-Trusted: 0 X-FuHaFi: 0.55 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Currently drivers/media drivers are linked very early - directly after base, block, misc, and mfd and before ata, scsi, ide, input, firewire, usb, and i2c. This breaks static build of video4linux drivers, that use generic CPU i2c adapter drivers and the v4l2-subdev subsystem, because during video4linux probing the v4l2-subdev core requires a struct i2c_adapter context, which cannot be satisfied before the i2c subsystem is initialised. Moving drivers/media after drivers/i2c fixes this problem. Signed-off-by: Guennadi Liakhovetski Acked-by: Jean Delvare --- The best way to trigger action is by submitting a patch:-) So, let's see what comes out of it - on the one hand I don't see any reason why media has to be linked this early, and nobody was able to give me one yesterday as this problem has been discussed on linux-media, OTOH, maybe indeed it would be better to move i2c the whole way up above media, but that'd be much bigger of a change, I think. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/Makefile b/drivers/Makefile index 2618a61..1266ead 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -36,7 +36,7 @@ obj-$(CONFIG_FB_INTEL) += video/intelfb/ obj-y += serial/ obj-$(CONFIG_PARPORT) += parport/ -obj-y += base/ block/ misc/ mfd/ media/ +obj-y += base/ block/ misc/ mfd/ obj-$(CONFIG_NUBUS) += nubus/ obj-y += macintosh/ obj-$(CONFIG_IDE) += ide/ @@ -71,7 +71,7 @@ obj-$(CONFIG_GAMEPORT) += input/gameport/ obj-$(CONFIG_INPUT) += input/ obj-$(CONFIG_I2O) += message/ obj-$(CONFIG_RTC_LIB) += rtc/ -obj-y += i2c/ +obj-y += i2c/ media/ obj-$(CONFIG_W1) += w1/ obj-$(CONFIG_POWER_SUPPLY) += power/ obj-$(CONFIG_HWMON) += hwmon/