| Message ID | Pine.LNX.4.64.0906101558090.4817@axis700.grange (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
Hi Guennadi, On Thursday 11 June 2009 09:12:37 Guennadi Liakhovetski wrote: > Add a new V4L2_CID_BAND_STOP_FILTER integer control, which either switches > the band-stop filter off, or sets it to a certain strength. I'm quoting your e-mail from 2009-05-27: > COMJ[2] - Band filter enable. After adjust frame rate to match indoor > light frequency, this bit enable a different exposure algorithm to cut > light band induced by fluorescent light. As Nate pointed out, that seems to some kind of anti-flicker control and not a band stop filter. Best regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 11 Jun 2009, Laurent Pinchart wrote: > Hi Guennadi, > > On Thursday 11 June 2009 09:12:37 Guennadi Liakhovetski wrote: > > Add a new V4L2_CID_BAND_STOP_FILTER integer control, which either switches > > the band-stop filter off, or sets it to a certain strength. > > I'm quoting your e-mail from 2009-05-27: > > > COMJ[2] - Band filter enable. After adjust frame rate to match indoor > > light frequency, this bit enable a different exposure algorithm to cut > > light band induced by fluorescent light. > > As Nate pointed out, that seems to some kind of anti-flicker control and not a > band stop filter. Well, it _is_ a band-stop filter, at least this is how it is referred to in the docs. It might be serving as an anti-flicker control, don't know, if that's going to be the consensus, we can rename it, sure. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index ebb2ea6..f50ec61 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -894,8 +894,10 @@ enum v4l2_colorfx { V4L2_COLORFX_SEPIA = 2, }; +#define V4L2_CID_BAND_STOP_FILTER (V4L2_CID_BASE+32) + /* last CID + 1 */ -#define V4L2_CID_LASTP1 (V4L2_CID_BASE+32) +#define V4L2_CID_LASTP1 (V4L2_CID_BASE+33) /* MPEG-class control IDs defined by V4L2 */ #define V4L2_CID_MPEG_BASE (V4L2_CTRL_CLASS_MPEG | 0x900)
Add a new V4L2_CID_BAND_STOP_FILTER integer control, which either switches the band-stop filter off, or sets it to a certain strength. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> --- include/linux/videodev2.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)