From patchwork Mon Jan 4 21:01:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 70735 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id o04L1OhZ023127 for ; Mon, 4 Jan 2010 21:01:24 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100Ab0ADVBL (ORCPT ); Mon, 4 Jan 2010 16:01:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754099Ab0ADVBK (ORCPT ); Mon, 4 Jan 2010 16:01:10 -0500 Received: from mail.gmx.net ([213.165.64.20]:35241 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754098Ab0ADVBJ (ORCPT ); Mon, 4 Jan 2010 16:01:09 -0500 Received: (qmail invoked by alias); 04 Jan 2010 21:01:07 -0000 Received: from p57BD18DA.dip0.t-ipconnect.de (EHLO axis700.grange) [87.189.24.218] by mail.gmx.net (mp070) with SMTP; 04 Jan 2010 22:01:07 +0100 X-Authenticated: #20450766 X-Provags-ID: V01U2FsdGVkX18k5ZlXTqwkmeXduEUt+ywJKjaMI/uuNLUnsffPym rl3OmJJvb9GL35 Received: from lyakh (helo=localhost) by axis700.grange with local-esmtp (Exim 4.63) (envelope-from ) id 1NRu31-0002Nw-LP; Mon, 04 Jan 2010 22:01:07 +0100 Date: Mon, 4 Jan 2010 22:01:07 +0100 (CET) From: Guennadi Liakhovetski To: =?ISO-8859-2?Q?N=E9meth_M=E1rton?= cc: Hans Verkuil , V4L Mailing List Subject: Re: [PATCH] rj54n1cb0c: remove compiler warning In-Reply-To: <4B40FF73.2060906@freemail.hu> Message-ID: References: <201001031950.o03JoIjh012466@smtp-vbr4.xs4all.nl> <4B40FF73.2060906@freemail.hu> MIME-Version: 1.0 X-Y-GMX-Trusted: 0 X-FuHaFi: 0.52 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From nm127@freemail.hu Sun Jan 3 21:38:51 2010 Date: Sun, 03 Jan 2010 21:34:59 +0100 From: Németh Márton To: Guennadi Liakhovetski Cc: Hans Verkuil , V4L Mailing List Subject: [PATCH] rj54n1cb0c: remove compiler warning From: Márton Németh Remove the following compiler warning: 'dummy' is used uninitialized in this function. Although the result in the dummy variable is not used the program flow in soc_camera_limit_side() depends on the value in dummy. The program flow is better to be deterministic. Signed-off-by: Márton Németh --- diff -r 62ee2b0f6556 linux/drivers/media/video/rj54n1cb0c.c --- a/linux/drivers/media/video/rj54n1cb0c.c Wed Dec 30 18:19:11 2009 +0100 +++ b/linux/drivers/media/video/rj54n1cb0c.c Sun Jan 03 21:30:20 2010 +0100 @@ -563,7 +563,7 @@ struct i2c_client *client = sd->priv; struct rj54n1 *rj54n1 = to_rj54n1(client); struct v4l2_rect *rect = &a->c; - unsigned int dummy, output_w, output_h, + unsigned int dummy = 0, output_w, output_h, input_w = rect->width, input_h = rect->height; int ret;