From patchwork Sat May 15 21:18:40 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 99892 X-Patchwork-Delegate: dougsland@redhat.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4FLJK5w015836 for ; Sat, 15 May 2010 21:19:20 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755678Ab0EOVSq (ORCPT ); Sat, 15 May 2010 17:18:46 -0400 Received: from mgw2.diku.dk ([130.225.96.92]:41729 "EHLO mgw2.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755487Ab0EOVSp (ORCPT ); Sat, 15 May 2010 17:18:45 -0400 Received: from localhost (localhost [127.0.0.1]) by mgw2.diku.dk (Postfix) with ESMTP id 89B8719BB6E; Sat, 15 May 2010 23:18:44 +0200 (CEST) Received: from mgw2.diku.dk ([127.0.0.1]) by localhost (mgw2.diku.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 08226-12; Sat, 15 May 2010 23:18:40 +0200 (CEST) Received: from nhugin.diku.dk (nhugin.diku.dk [130.225.96.140]) by mgw2.diku.dk (Postfix) with ESMTP id 741B419BB6D; Sat, 15 May 2010 23:18:40 +0200 (CEST) Received: from ask.diku.dk (ask.diku.dk [130.225.96.225]) by nhugin.diku.dk (Postfix) with ESMTP id ECEF26DFD1E; Sat, 15 May 2010 23:11:28 +0200 (CEST) Received: by ask.diku.dk (Postfix, from userid 3767) id 549E2200BE; Sat, 15 May 2010 23:18:40 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by ask.diku.dk (Postfix) with ESMTP id 4DCF8200BC; Sat, 15 May 2010 23:18:40 +0200 (CEST) Date: Sat, 15 May 2010 23:18:40 +0200 (CEST) From: Julia Lawall To: Huang Shijie , Kang Yong , Zhang Xiaobing , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 18/37] drivers/media/video/tlg2300: Use kmemdup Message-ID: MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Sat, 15 May 2010 21:19:20 +0000 (UTC) diff -u -p a/drivers/media/video/tlg2300/pd-main.c b/drivers/media/video/tlg2300/pd-main.c --- a/drivers/media/video/tlg2300/pd-main.c +++ b/drivers/media/video/tlg2300/pd-main.c @@ -227,12 +227,11 @@ static int firmware_download(struct usb_ fwlength = fw->size; - fwbuf = kzalloc(fwlength, GFP_KERNEL); + fwbuf = kmemdup(fw->data, fwlength, GFP_KERNEL); if (!fwbuf) { ret = -ENOMEM; goto out; } - memcpy(fwbuf, fw->data, fwlength); max_packet_size = udev->ep_out[0x1]->desc.wMaxPacketSize; log("\t\t download size : %d", (int)max_packet_size);