| Message ID | Pine.LNX.4.64.1106061915210.11169@axis700.grange (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
Morimoto-san, sorry, that was a wrong address of yours again in the original mail. With the correct request also comes a request: would it be difficult for you to give this patch a try? If you don't happen to have a set up ready at hand, no problem, I'll dig out some video signal source myself and test. Thanks Guennadi On Mon, 6 Jun 2011, Guennadi Liakhovetski wrote: > tw9910 is a TV decoder, it doesn't have a tuner. Besides, the > .enum_input soc-camera operation is optional and normally not needed. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > --- > drivers/media/video/tw9910.c | 11 ----------- > 1 files changed, 0 insertions(+), 11 deletions(-) > > diff --git a/drivers/media/video/tw9910.c b/drivers/media/video/tw9910.c > index 0347bbe..a722f66 100644 > --- a/drivers/media/video/tw9910.c > +++ b/drivers/media/video/tw9910.c > @@ -552,16 +552,6 @@ static int tw9910_s_std(struct v4l2_subdev *sd, v4l2_std_id norm) > return ret; > } > > -static int tw9910_enum_input(struct soc_camera_device *icd, > - struct v4l2_input *inp) > -{ > - inp->type = V4L2_INPUT_TYPE_TUNER; > - inp->std = V4L2_STD_UNKNOWN; > - strcpy(inp->name, "Video"); > - > - return 0; > -} > - > static int tw9910_g_chip_ident(struct v4l2_subdev *sd, > struct v4l2_dbg_chip_ident *id) > { > @@ -891,7 +881,6 @@ static int tw9910_video_probe(struct soc_camera_device *icd, > static struct soc_camera_ops tw9910_ops = { > .set_bus_param = tw9910_set_bus_param, > .query_bus_param = tw9910_query_bus_param, > - .enum_input = tw9910_enum_input, > }; > > static struct v4l2_subdev_core_ops tw9910_subdev_core_ops = { > -- > 1.7.2.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Guennadi Thank you for your email. > Morimoto-san, sorry, that was a wrong address of yours again in the > original mail. With the correct request also comes a request: would it be > difficult for you to give this patch a try? If you don't happen to have a > set up ready at hand, no problem, I'll dig out some video signal source > myself and test. I'm sorry too. I don't know why, but I had lost V4L2 ML since last month somehow. I didn't notice about it. I tried this patch on SH7724 Ecovec board. I'm using NTSC video player, and it works well. But I just played video. Is this test OK for you ? Best regards -- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 7 Jun 2011, Kuninori Morimoto wrote: > > Dear Guennadi > > Thank you for your email. > > > Morimoto-san, sorry, that was a wrong address of yours again in the > > original mail. With the correct request also comes a request: would it be > > difficult for you to give this patch a try? If you don't happen to have a > > set up ready at hand, no problem, I'll dig out some video signal source > > myself and test. > > I'm sorry too. > I don't know why, but I had lost V4L2 ML since last month somehow. > I didn't notice about it. > > I tried this patch on SH7724 Ecovec board. > I'm using NTSC video player, and it works well. > > But I just played video. > Is this test OK for you ? Yes, very good, thanks very much! Can I add your "Tested-by" to the patch? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Dear Guennadi > > I tried this patch on SH7724 Ecovec board. > > I'm using NTSC video player, and it works well. > > > > But I just played video. > > Is this test OK for you ? > > Yes, very good, thanks very much! Can I add your "Tested-by" to the patch? Thanks. Yes, please add it Best regards -- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/video/tw9910.c b/drivers/media/video/tw9910.c index 0347bbe..a722f66 100644 --- a/drivers/media/video/tw9910.c +++ b/drivers/media/video/tw9910.c @@ -552,16 +552,6 @@ static int tw9910_s_std(struct v4l2_subdev *sd, v4l2_std_id norm) return ret; } -static int tw9910_enum_input(struct soc_camera_device *icd, - struct v4l2_input *inp) -{ - inp->type = V4L2_INPUT_TYPE_TUNER; - inp->std = V4L2_STD_UNKNOWN; - strcpy(inp->name, "Video"); - - return 0; -} - static int tw9910_g_chip_ident(struct v4l2_subdev *sd, struct v4l2_dbg_chip_ident *id) { @@ -891,7 +881,6 @@ static int tw9910_video_probe(struct soc_camera_device *icd, static struct soc_camera_ops tw9910_ops = { .set_bus_param = tw9910_set_bus_param, .query_bus_param = tw9910_query_bus_param, - .enum_input = tw9910_enum_input, }; static struct v4l2_subdev_core_ops tw9910_subdev_core_ops = {
tw9910 is a TV decoder, it doesn't have a tuner. Besides, the .enum_input soc-camera operation is optional and normally not needed. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> --- drivers/media/video/tw9910.c | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-)