From patchwork Tue Sep 11 12:58:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 1437591 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id EE8F3DFAF3 for ; Tue, 11 Sep 2012 12:59:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751120Ab2IKM67 (ORCPT ); Tue, 11 Sep 2012 08:58:59 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:58181 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040Ab2IKM67 (ORCPT ); Tue, 11 Sep 2012 08:58:59 -0400 Received: from axis700.grange (dslb-094-220-153-146.pools.arcor-ip.net [94.220.153.146]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0LzHaz-1Tg5zc1xbN-014qHP; Tue, 11 Sep 2012 14:58:57 +0200 Received: by axis700.grange (Postfix, from userid 1000) id 066C4189B0D; Tue, 11 Sep 2012 14:58:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by axis700.grange (Postfix) with ESMTP id F205E189AF7 for ; Tue, 11 Sep 2012 14:58:56 +0200 (CEST) Date: Tue, 11 Sep 2012 14:58:56 +0200 (CEST) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Linux Media Mailing List Subject: [PATCH] media: use list_first_entry() instead of open-coding in mem2mem core Message-ID: MIME-Version: 1.0 X-Provags-ID: V02:K0:hd8y/cdLg1WtTZ4pn6D3lg0pT2x3dGQp2/kDQD54dFf CJkSvVm41R4eBePPRyIPZW88Bf9AQwMOFiKUnWuVDIQp3Dsn3s tlr+Gf+8EEgfQzN21NxFfVpVISOxAEV3GIymm3Zm6AkRZfmpHv LOs3QnPBe4BtqNFL1uo+NQ4igEZZDHc9X5xS1W6C9iMgcZXxOq tt/p1MHE8VLfLncxxTFxaXqprxe/22pH1vF3iLVxCzdgcePjnk 7l6fMNHJqBzUgZZy46QqSCc/mQHtxu2AX81a8Q88bk4k36Cxfa Zxc8tCURYyQz3yGhWxSLKJg7IhhfJZ2lOcEVGdvpTRIDUOuqkb 4JN2CLd3Rki/xRHO0T8MViEvHzmm2ZTUA1PcM9n06YvYaplzZk Ca43oRRwOMZgw== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Using list_first_entry() improves code readability and makes it less error-prone. Signed-off-by: Guennadi Liakhovetski --- drivers/media/v4l2-core/v4l2-mem2mem.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c index 97b4831..3ac8358 100644 --- a/drivers/media/v4l2-core/v4l2-mem2mem.c +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c @@ -105,7 +105,7 @@ void *v4l2_m2m_next_buf(struct v4l2_m2m_queue_ctx *q_ctx) return NULL; } - b = list_entry(q_ctx->rdy_queue.next, struct v4l2_m2m_buffer, list); + b = list_first_entry(&q_ctx->rdy_queue, struct v4l2_m2m_buffer, list); spin_unlock_irqrestore(&q_ctx->rdy_spinlock, flags); return &b->vb; } @@ -125,7 +125,7 @@ void *v4l2_m2m_buf_remove(struct v4l2_m2m_queue_ctx *q_ctx) spin_unlock_irqrestore(&q_ctx->rdy_spinlock, flags); return NULL; } - b = list_entry(q_ctx->rdy_queue.next, struct v4l2_m2m_buffer, list); + b = list_first_entry(&q_ctx->rdy_queue, struct v4l2_m2m_buffer, list); list_del(&b->list); q_ctx->num_rdy--; spin_unlock_irqrestore(&q_ctx->rdy_spinlock, flags); @@ -178,7 +178,7 @@ static void v4l2_m2m_try_run(struct v4l2_m2m_dev *m2m_dev) return; } - m2m_dev->curr_ctx = list_entry(m2m_dev->job_queue.next, + m2m_dev->curr_ctx = list_first_entry(&m2m_dev->job_queue, struct v4l2_m2m_ctx, queue); m2m_dev->curr_ctx->job_flags |= TRANS_RUNNING; spin_unlock_irqrestore(&m2m_dev->job_spinlock, flags);