From patchwork Fri Mar 8 11:25:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guennadi Liakhovetski X-Patchwork-Id: 2236841 Return-Path: X-Original-To: patchwork-linux-media@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id D97C84006E for ; Fri, 8 Mar 2013 11:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752764Ab3CHLZ3 (ORCPT ); Fri, 8 Mar 2013 06:25:29 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:62531 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522Ab3CHLZ3 (ORCPT ); Fri, 8 Mar 2013 06:25:29 -0500 Received: from axis700.grange (dslb-178-006-080-107.pools.arcor-ip.net [178.6.80.107]) by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis) id 0LyDKf-1UsCKw3HiX-015ctM; Fri, 08 Mar 2013 12:25:27 +0100 Received: by axis700.grange (Postfix, from userid 1000) id 32C4840BB4; Fri, 8 Mar 2013 12:25:27 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by axis700.grange (Postfix) with ESMTP id 29B3340BB3; Fri, 8 Mar 2013 12:25:27 +0100 (CET) Date: Fri, 8 Mar 2013 12:25:27 +0100 (CET) From: Guennadi Liakhovetski X-X-Sender: lyakh@axis700.grange To: Linux Media Mailing List cc: Janusz Krzysztofik Subject: [PATCH] soc-camera: fix typos in the default format-conversion table Message-ID: MIME-Version: 1.0 X-Provags-ID: V02:K0:tgVD+obIRtjXVwxOdygu29oXllz5LtGd9JwK3Bn4Uck GVX4fivzOr5Qm279Y6m2FtlRXqaJmP9c5LCLkflmPEQtLI3Qpx HJqVhpscKM8C4zHueMxhTHetlRXwrL204ugemr7iIMUa7/9Kf6 dGhJHZkxDEC3L7L+NmbzWJ4dCdoPq+7OW8dBWpTJpq/iJrZS1d ylwY7rPMV9IiXt6sEz4qNtXYthhmOqcTAkY8etXyB7TAvfhdbU OHPrr+5gt29D/hhxA6KWLcrPeFCfdMnFb5qEkRWY2L0iek2DP3 t2joBqFEVMnXTHkxePTvRJmkxt67N5Pqie//yeV9fQM9Fkac/a euIASo7652W4EzMCWP31LlBuT71CmPq95AKozNj34po9AWe30Q pn4kja7v4MPkw== Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The default format conversion table mbus_fmt[] in soc_mediabus.c lists "natural" conversions between media-bus and fourcc pixel formats, that are achieved by storing data from the bus in RAM exactly as it arrives, only possibly padding missing high or low bits. Such data acquisition mode cannot change data endianness, therefore two locations with opposite endianness are erroneous. This change might affest the omap1-camera driver, existing configurations should be verified. Cc: Janusz Krzysztofik Signed-off-by: Guennadi Liakhovetski --- drivers/media/platform/soc_camera/soc_mediabus.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/soc_camera/soc_mediabus.c b/drivers/media/platform/soc_camera/soc_mediabus.c index a397812..1f6d695 100644 --- a/drivers/media/platform/soc_camera/soc_mediabus.c +++ b/drivers/media/platform/soc_camera/soc_mediabus.c @@ -73,7 +73,7 @@ static const struct soc_mbus_lookup mbus_fmt[] = { .name = "RGB555X", .bits_per_sample = 8, .packing = SOC_MBUS_PACKING_2X8_PADHI, - .order = SOC_MBUS_ORDER_LE, + .order = SOC_MBUS_ORDER_BE, .layout = SOC_MBUS_LAYOUT_PACKED, }, }, { @@ -93,7 +93,7 @@ static const struct soc_mbus_lookup mbus_fmt[] = { .name = "RGB565X", .bits_per_sample = 8, .packing = SOC_MBUS_PACKING_2X8_PADHI, - .order = SOC_MBUS_ORDER_LE, + .order = SOC_MBUS_ORDER_BE, .layout = SOC_MBUS_LAYOUT_PACKED, }, }, {